Re: [PATCH 2/2] watchdog: Add Nuvoton NPCM watchdog driver

2018-03-04 Thread Joel Stanley
On Sat, Mar 3, 2018 at 12:29 AM, Guenter Roeck wrote: >> +static int npcm_wdt_start(struct watchdog_device *wdd) >> +{ >> + struct npcm_wdt *wdt = to_npcm_wdt(wdd); >> + u32 val; >> + >> + val = NPCM_WTRE | NPCM_WTE | NPCM_WTR | NPCM_WTIE; >> + >> + if (wdd->timeout < 2) >>

Re: [PATCH 2/2] watchdog: Add Nuvoton NPCM watchdog driver

2018-03-04 Thread Joel Stanley
On Fri, Mar 2, 2018 at 9:50 PM, Marcus Folkesson wrote: > Hello Joel! > > On Fri, Mar 02, 2018 at 05:07:46PM +1030, Joel Stanley wrote: >> The Nuvoton NPCM750 has a watchdog implemented as a single register >> inside the timer peripheral. >> >> This driver exposes that watchdog as a standard watch

Re: [PATCH 2/2] watchdog: Add Nuvoton NPCM watchdog driver

2018-03-02 Thread Guenter Roeck
On 03/01/2018 10:37 PM, Joel Stanley wrote: The Nuvoton NPCM750 has a watchdog implemented as a single register inside the timer peripheral. This driver exposes that watchdog as a standard watchdog device with coarse timeout intervals, limited by the combination of prescaler and counter that is

Re: [PATCH 2/2] watchdog: Add Nuvoton NPCM watchdog driver

2018-03-02 Thread Marcus Folkesson
Hello Joel! On Fri, Mar 02, 2018 at 05:07:46PM +1030, Joel Stanley wrote: > The Nuvoton NPCM750 has a watchdog implemented as a single register > inside the timer peripheral. > > This driver exposes that watchdog as a standard watchdog device with > coarse timeout intervals, limited by the combin

[PATCH 2/2] watchdog: Add Nuvoton NPCM watchdog driver

2018-03-01 Thread Joel Stanley
The Nuvoton NPCM750 has a watchdog implemented as a single register inside the timer peripheral. This driver exposes that watchdog as a standard watchdog device with coarse timeout intervals, limited by the combination of prescaler and counter that is provided by the hardware. The calculation is t