Re: [PATCH 2/2] w1: fix the resume command API

2019-03-21 Thread Mariusz Bialonczyk
Hi Evgeniy, On Tue, 19 Mar 2019 17:21:09 +0300 Evgeniy Polyakov wrote: > Looks like this may break the search logic, can you check that with this > patch applied > some other single slave device will correctly 'tell' its id and it can be > addressed via match rom (like, basically, just reading

Re: [PATCH 2/2] w1: fix the resume command API

2019-03-19 Thread Evgeniy Polyakov
Hi everyone Mariusz, thank you for the patch, a small comment on it logic 19.03.2019, 16:21, "Jean-Francois Dagenais" : >>  --- >>  drivers/w1/w1_io.c | 11 +-- >>  1 file changed, 9 insertions(+), 2 deletions(-) >> >>  diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c >>  index 0364d3

Re: [PATCH 2/2] w1: fix the resume command API

2019-03-19 Thread Jean-Francois Dagenais
Hi Mariusz, I appreciate your work on this. > On Mar 18, 2019, at 05:27, Mariusz Bialonczyk wrote: > > From the DS2408 datasheet [1]: > "Resume Command function checks the status of the RC flag and, if it is set, > directly transfers control to the control functions, similar to a Skip ROM > com

[PATCH 2/2] w1: fix the resume command API

2019-03-18 Thread Mariusz Bialonczyk
>From the DS2408 datasheet [1]: "Resume Command function checks the status of the RC flag and, if it is set, directly transfers control to the control functions, similar to a Skip ROM command. The only way to set the RC flag is through successfully executing the Match ROM, Search ROM, Conditiona