Re: [PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device

2020-09-18 Thread Zenghui Yu
On 2020/9/19 10:11, Alex Williamson wrote: On Sat, 19 Sep 2020 09:54:00 +0800 Zenghui Yu wrote: Hi Alex, On 2020/9/18 6:07, Alex Williamson wrote: On Thu, 17 Sep 2020 13:35:37 +0200 Cornelia Huck wrote: On Thu, 17 Sep 2020 11:31:28 +0800 Zenghui Yu wrote: It isn't clear what purpo

Re: [PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device

2020-09-18 Thread Alex Williamson
On Sat, 19 Sep 2020 09:54:00 +0800 Zenghui Yu wrote: > Hi Alex, > > On 2020/9/18 6:07, Alex Williamson wrote: > > On Thu, 17 Sep 2020 13:35:37 +0200 > > Cornelia Huck wrote: > > > >> On Thu, 17 Sep 2020 11:31:28 +0800 > >> Zenghui Yu wrote: > >> > >>> It isn't clear what purpose the @bard

Re: [PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device

2020-09-18 Thread Zenghui Yu
Hi Alex, On 2020/9/18 6:07, Alex Williamson wrote: On Thu, 17 Sep 2020 13:35:37 +0200 Cornelia Huck wrote: On Thu, 17 Sep 2020 11:31:28 +0800 Zenghui Yu wrote: It isn't clear what purpose the @bardirty serves. It might be used to avoid the unnecessary vfio_bar_fixup() invoking on a user-sp

Re: [PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device

2020-09-17 Thread Alex Williamson
On Thu, 17 Sep 2020 13:35:37 +0200 Cornelia Huck wrote: > On Thu, 17 Sep 2020 11:31:28 +0800 > Zenghui Yu wrote: > > > It isn't clear what purpose the @bardirty serves. It might be used to avoid > > the unnecessary vfio_bar_fixup() invoking on a user-space BAR read, which > > is not required wh

Re: [PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device

2020-09-17 Thread Cornelia Huck
On Thu, 17 Sep 2020 11:31:28 +0800 Zenghui Yu wrote: > It isn't clear what purpose the @bardirty serves. It might be used to avoid > the unnecessary vfio_bar_fixup() invoking on a user-space BAR read, which > is not required when bardirty is unset. > > The variable was introduced in commit 89e1f

[PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device

2020-09-16 Thread Zenghui Yu
It isn't clear what purpose the @bardirty serves. It might be used to avoid the unnecessary vfio_bar_fixup() invoking on a user-space BAR read, which is not required when bardirty is unset. The variable was introduced in commit 89e1f7d4c66d ("vfio: Add PCI device driver") but never actually used,