Re: [PATCH 2/2] usb/ftdi_sio: Add support for setting CBUS pins on FT232H

2014-06-01 Thread Philipp Hachtmann
On 02.06.2014 03:38, Greg KH wrote: >> Yes but... I should have avoided the term "GPIO".> No, you used the right term :) Sorry for using the right term :) > No, I am not going to add custom ioctls to a single driver for this. I did neither request nor expect that - did it sound that way? > It

Re: [PATCH 2/2] usb/ftdi_sio: Add support for setting CBUS pins on FT232H

2014-06-01 Thread Greg KH
On Mon, Jun 02, 2014 at 02:57:39AM +0200, Philipp Hachtmann wrote: > On 01.06.2014 04:31, Greg KH wrote: > >As they are GPIO pins on this device, it should be the subsystem that > >controls it. That way, userspace programs that are used to talk to a > >GPIO device will "just work", and not have to

Re: [PATCH 2/2] usb/ftdi_sio: Add support for setting CBUS pins on FT232H

2014-06-01 Thread Philipp Hachtmann
On 01.06.2014 04:31, Greg KH wrote: As they are GPIO pins on this device, it should be the subsystem that controls it. That way, userspace programs that are used to talk to a GPIO device will "just work", and not have to be customized just for this specific device and sysfs file. So please us

Re: [PATCH 2/2] usb/ftdi_sio: Add support for setting CBUS pins on FT232H

2014-05-31 Thread Greg KH
On Sun, Jun 01, 2014 at 02:14:27AM +0200, Philipp Hachtmann wrote: > On 01.06.2014 02:00, Peter Stuge wrote: > >Philipp Hachtmann wrote: > >>This patch adds a sysfs attribute "cbus" which allows to set the > >>four CBUS pins on the FT232H. > > > >I think this should be implemented with the gpio sub

Re: [PATCH 2/2] usb/ftdi_sio: Add support for setting CBUS pins on FT232H

2014-05-31 Thread Philipp Hachtmann
On 01.06.2014 02:00, Peter Stuge wrote: Philipp Hachtmann wrote: This patch adds a sysfs attribute "cbus" which allows to set the four CBUS pins on the FT232H. I think this should be implemented with the gpio subsystem instead. The GPIO subsystem seems to be made for GPIO pins connected direct

Re: [PATCH 2/2] usb/ftdi_sio: Add support for setting CBUS pins on FT232H

2014-05-31 Thread Peter Stuge
Philipp Hachtmann wrote: > This patch adds a sysfs attribute "cbus" which allows to set the > four CBUS pins on the FT232H. I think this should be implemented with the gpio subsystem instead. //Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

Re: [PATCH 2/2] usb/ftdi_sio: Add support for setting CBUS pins on FT232H

2014-05-31 Thread Philipp Hachtmann
On 01.06.2014 01:31, Philipp Hachtmann wrote: This patch adds a sysfs attribute "cbus" which allows to set the four CBUS pins on the FT232H. The patch contains a *small* error that happened when splitting up my modifications. Next series will contain the clean variant. -- To unsubscribe from

[PATCH 2/2] usb/ftdi_sio: Add support for setting CBUS pins on FT232H

2014-05-31 Thread Philipp Hachtmann
This patch adds a sysfs attribute "cbus" which allows to set the four CBUS pins on the FT232H. CBUS support could probably extended to all supporting FTDI chips. Signed-off-by: Philipp Hachtmann --- drivers/usb/serial/ftdi_sio.c | 66 ++- drivers/usb/seri