Re: [PATCH 2/2] tty: serial: msm: Support sysrq on uartDM devices

2014-11-03 Thread Frank Rowand
On 11/3/2014 2:05 AM, Daniel Thompson wrote: > On 31/10/14 18:08, Frank Rowand wrote: >> On 10/31/2014 2:43 AM, Daniel Thompson wrote: >>> On 31/10/14 06:41, Stephen Boyd wrote: On 10/30, Daniel Thompson wrote: > On 29/10/14 18:14, Stephen Boyd wrote: >> +r_count = min_

Re: [PATCH 2/2] tty: serial: msm: Support sysrq on uartDM devices

2014-11-03 Thread Daniel Thompson
On 31/10/14 18:08, Frank Rowand wrote: > On 10/31/2014 2:43 AM, Daniel Thompson wrote: >> On 31/10/14 06:41, Stephen Boyd wrote: >>> On 10/30, Daniel Thompson wrote: On 29/10/14 18:14, Stephen Boyd wrote: > + r_count = min_t(int, count, sizeof(buf)); > + > + for (i

Re: [PATCH 2/2] tty: serial: msm: Support sysrq on uartDM devices

2014-10-31 Thread Frank Rowand
On 10/31/2014 2:43 AM, Daniel Thompson wrote: > On 31/10/14 06:41, Stephen Boyd wrote: >> On 10/30, Daniel Thompson wrote: >>> On 29/10/14 18:14, Stephen Boyd wrote: + r_count = min_t(int, count, sizeof(buf)); + + for (i = 0; i < r_count; i++) { +

Re: [PATCH 2/2] tty: serial: msm: Support sysrq on uartDM devices

2014-10-31 Thread Daniel Thompson
On 31/10/14 06:41, Stephen Boyd wrote: > On 10/30, Daniel Thompson wrote: >> On 29/10/14 18:14, Stephen Boyd wrote: >>> + r_count = min_t(int, count, sizeof(buf)); >>> + >>> + for (i = 0; i < r_count; i++) { >>> + char flag = TTY_NORMAL; >>> >>> - /

Re: [PATCH 2/2] tty: serial: msm: Support sysrq on uartDM devices

2014-10-30 Thread Stephen Boyd
On 10/30, Daniel Thompson wrote: > On 29/10/14 18:14, Stephen Boyd wrote: > > + r_count = min_t(int, count, sizeof(buf)); > > + > > + for (i = 0; i < r_count; i++) { > > + char flag = TTY_NORMAL; > > > > - /* TODO: handle sysrq */ > > - tt

Re: [PATCH 2/2] tty: serial: msm: Support sysrq on uartDM devices

2014-10-30 Thread Daniel Thompson
On 29/10/14 18:14, Stephen Boyd wrote: > To properly support sysrq on uartDM hardware we need to properly > handle break characters. With the DM hardware the fifo can pack 4 > characters at a time, where a break is indicated by an all zero > byte. Unfortunately, we can't differentiate between an al

[PATCH 2/2] tty: serial: msm: Support sysrq on uartDM devices

2014-10-29 Thread Stephen Boyd
To properly support sysrq on uartDM hardware we need to properly handle break characters. With the DM hardware the fifo can pack 4 characters at a time, where a break is indicated by an all zero byte. Unfortunately, we can't differentiate between an all zero byte for a break and an all zero byte of