Re: [PATCH 2/2] tracing: Add support for critical section events

2017-09-06 Thread Joel Fernandes
Hi Peter, On Wed, Sep 6, 2017 at 1:40 AM, Peter Zijlstra wrote: > On Tue, Sep 05, 2017 at 09:35:11AM -0700, Joel Fernandes wrote: >> On Mon, Sep 4, 2017 at 11:52 PM, Peter Zijlstra wrote: >> > On Mon, Sep 04, 2017 at 08:26:13PM -0700, Joel Fernandes wrote: >> > >> >> Apologies, I meant (without

Re: [PATCH 2/2] tracing: Add support for critical section events

2017-09-06 Thread Peter Zijlstra
On Tue, Sep 05, 2017 at 09:35:11AM -0700, Joel Fernandes wrote: > On Mon, Sep 4, 2017 at 11:52 PM, Peter Zijlstra wrote: > > On Mon, Sep 04, 2017 at 08:26:13PM -0700, Joel Fernandes wrote: > > > >> Apologies, I meant (without the "off"): > >> > >> subsystem: atomic_section > >> events: > >> irqs

Re: [PATCH 2/2] tracing: Add support for critical section events

2017-09-05 Thread Joel Fernandes
On Mon, Sep 4, 2017 at 11:52 PM, Peter Zijlstra wrote: > On Mon, Sep 04, 2017 at 08:26:13PM -0700, Joel Fernandes wrote: > >> Apologies, I meant (without the "off"): >> >> subsystem: atomic_section >> events: >> irqs_disable >> irqs_enable >> preempt_disable >> preempt_enable >> >> and add

Re: [PATCH 2/2] tracing: Add support for critical section events

2017-09-04 Thread Peter Zijlstra
On Mon, Sep 04, 2017 at 08:26:13PM -0700, Joel Fernandes wrote: > Apologies, I meant (without the "off"): > > subsystem: atomic_section > events: > irqs_disable > irqs_enable > preempt_disable > preempt_enable > > and additionally (similar to what my patch does): > preemptirq_enable >

Re: [PATCH 2/2] tracing: Add support for critical section events

2017-09-04 Thread Joel Fernandes
On Mon, Sep 4, 2017 at 5:54 PM, Joel Fernandes wrote: > On Mon, Sep 4, 2017 at 4:34 PM, Steven Rostedt wrote: >> On Mon, 4 Sep 2017 21:44:26 +0200 >> Peter Zijlstra wrote: >> >>> > I can change the name to something else, but at the moment I can't >>> > think of anything better. Could you sugges

Re: [PATCH 2/2] tracing: Add support for critical section events

2017-09-04 Thread Joel Fernandes
On Mon, Sep 4, 2017 at 4:34 PM, Steven Rostedt wrote: > On Mon, 4 Sep 2017 21:44:26 +0200 > Peter Zijlstra wrote: > >> > I can change the name to something else, but at the moment I can't >> > think of anything better. Could you suggest a better name? Also btw, >> > 'critical timings' is the term

Re: [PATCH 2/2] tracing: Add support for critical section events

2017-09-04 Thread Steven Rostedt
On Mon, 4 Sep 2017 21:44:26 +0200 Peter Zijlstra wrote: > > I can change the name to something else, but at the moment I can't > > think of anything better. Could you suggest a better name? Also btw, > > 'critical timings' is the terminology used within the irqsoff tracer > > so this is in line w

Re: [PATCH 2/2] tracing: Add support for critical section events

2017-09-04 Thread Peter Zijlstra
On Mon, Sep 04, 2017 at 12:04:44PM -0700, Joel Fernandes wrote: > Hi Peter, > > On Mon, Sep 4, 2017 at 12:56 AM, Peter Zijlstra wrote: > > On Sun, Sep 03, 2017 at 01:50:51AM -0700, Joel Fernandes wrote: > >> Critical section trace events can be used for tracing the start and > >> end of a critica

Re: [PATCH 2/2] tracing: Add support for critical section events

2017-09-04 Thread Joel Fernandes
Hi Peter, On Mon, Sep 4, 2017 at 12:56 AM, Peter Zijlstra wrote: > On Sun, Sep 03, 2017 at 01:50:51AM -0700, Joel Fernandes wrote: >> Critical section trace events can be used for tracing the start and >> end of a critical section which can be used by a trace viewer like >> systrace to graphicall

Re: [PATCH 2/2] tracing: Add support for critical section events

2017-09-04 Thread Peter Zijlstra
On Sun, Sep 03, 2017 at 01:50:51AM -0700, Joel Fernandes wrote: > Critical section trace events can be used for tracing the start and > end of a critical section which can be used by a trace viewer like > systrace to graphically view the start and end of a critical section and > correlate them with

[PATCH 2/2] tracing: Add support for critical section events

2017-09-03 Thread Joel Fernandes
Critical section trace events can be used for tracing the start and end of a critical section which can be used by a trace viewer like systrace to graphically view the start and end of a critical section and correlate them with latencies and scheduling issues. Reason for starting critical section: