Re: [PATCH 2/2] trace_uprobe: Simplify probes_seq_show()

2018-03-07 Thread Kees Cook
On Tue, Mar 6, 2018 at 8:12 PM, Ravi Bangoria wrote: > > > On 03/07/2018 03:34 AM, Kees Cook wrote: >> On Tue, Mar 6, 2018 at 12:12 AM, Ravi Bangoria >> wrote: >>> >>> On 02/08/2018 09:13 AM, Ravi Bangoria wrote: Wang, ping :) Kees, I don't hear back from Wang and no one has report

Re: [PATCH 2/2] trace_uprobe: Simplify probes_seq_show()

2018-03-06 Thread Ravi Bangoria
On 03/07/2018 03:34 AM, Kees Cook wrote: > On Tue, Mar 6, 2018 at 12:12 AM, Ravi Bangoria > wrote: >> >> On 02/08/2018 09:13 AM, Ravi Bangoria wrote: >>> Wang, ping :) >>> >>> Kees, I don't hear back from Wang and no one has reported any issues with >>> the patches yet. Can I have your Acked-by?

Re: [PATCH 2/2] trace_uprobe: Simplify probes_seq_show()

2018-03-06 Thread Kees Cook
On Tue, Mar 6, 2018 at 12:12 AM, Ravi Bangoria wrote: > > > On 02/08/2018 09:13 AM, Ravi Bangoria wrote: >> >> On 02/08/2018 08:59 AM, Kees Cook wrote: >>> On Tue, Feb 6, 2018 at 8:34 PM, Ravi Bangoria >>> wrote: Simplify probes_seq_show() function. We are using %lx to display the offse

Re: [PATCH 2/2] trace_uprobe: Simplify probes_seq_show()

2018-03-06 Thread Ravi Bangoria
On 02/08/2018 09:13 AM, Ravi Bangoria wrote: > > On 02/08/2018 08:59 AM, Kees Cook wrote: >> On Tue, Feb 6, 2018 at 8:34 PM, Ravi Bangoria >> wrote: >>> Simplify probes_seq_show() function. We are using %lx to display >>> the offset and we don't prepend unnecessary 0s in the offset. >>> >>> Sign

Re: [PATCH 2/2] trace_uprobe: Simplify probes_seq_show()

2018-02-07 Thread Ravi Bangoria
On 02/08/2018 08:59 AM, Kees Cook wrote: > On Tue, Feb 6, 2018 at 8:34 PM, Ravi Bangoria > wrote: >> Simplify probes_seq_show() function. We are using %lx to display >> the offset and we don't prepend unnecessary 0s in the offset. >> >> Signed-off-by: Ravi Bangoria >> --- >> kernel/trace/trace

Re: [PATCH 2/2] trace_uprobe: Simplify probes_seq_show()

2018-02-07 Thread Kees Cook
On Tue, Feb 6, 2018 at 8:34 PM, Ravi Bangoria wrote: > Simplify probes_seq_show() function. We are using %lx to display > the offset and we don't prepend unnecessary 0s in the offset. > > Signed-off-by: Ravi Bangoria > --- > kernel/trace/trace_uprobe.c | 21 +++-- > 1 file change

Re: [PATCH 2/2] trace_uprobe: Simplify probes_seq_show()

2018-02-06 Thread Srikar Dronamraju
> Simplify probes_seq_show() function. We are using %lx to display > the offset and we don't prepend unnecessary 0s in the offset. > The prepending of 0s was introduced by tracing/uprobes: Do not print '0x (null)' when offset is 0 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.

[PATCH 2/2] trace_uprobe: Simplify probes_seq_show()

2018-02-06 Thread Ravi Bangoria
Simplify probes_seq_show() function. We are using %lx to display the offset and we don't prepend unnecessary 0s in the offset. Signed-off-by: Ravi Bangoria --- kernel/trace/trace_uprobe.c | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/kernel/trace/trac