Re: [PATCH 2/2] ti-adc081c: Initial triggered buffer support

2016-04-03 Thread Jonathan Cameron
On 01/04/16 09:34, Peter Meerwald-Stadler wrote: > >> Using this requires software triggers like CONFIG_IIO_HRTIMER_TRIGGER. >> >> The device can be configured to do internal periodic sampling but does >> not appear to offer some sort of interrupt on data ready. It only offers >> interrupts on val

Re: [PATCH 2/2] ti-adc081c: Initial triggered buffer support

2016-04-01 Thread Leonard Crestez
On 04/01/2016 11:34 AM, Peter Meerwald-Stadler wrote: -static const struct iio_chan_spec adc081c_channel = { - .type = IIO_VOLTAGE, - .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), - .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), -}; the patch would look cleaner/shorter

Re: [PATCH 2/2] ti-adc081c: Initial triggered buffer support

2016-04-01 Thread Lars-Peter Clausen
On 04/01/2016 10:08 AM, Crt Mori wrote: > On 31 March 2016 at 19:20, Crestez Dan Leonard > wrote: >> Using this requires software triggers like CONFIG_IIO_HRTIMER_TRIGGER. > Then we are missing DEPENDS in Kconfig... The device could be used with any generic trigger. The device driver shouldn't ma

Re: [PATCH 2/2] ti-adc081c: Initial triggered buffer support

2016-04-01 Thread Peter Meerwald-Stadler
> Using this requires software triggers like CONFIG_IIO_HRTIMER_TRIGGER. > > The device can be configured to do internal periodic sampling but does > not appear to offer some sort of interrupt on data ready. It only offers > interrupts on values out of a specific range. > > Signed-off-by: Creste

Re: [PATCH 2/2] ti-adc081c: Initial triggered buffer support

2016-04-01 Thread Crt Mori
On 31 March 2016 at 19:20, Crestez Dan Leonard wrote: > Using this requires software triggers like CONFIG_IIO_HRTIMER_TRIGGER. Then we are missing DEPENDS in Kconfig... > > The device can be configured to do internal periodic sampling but does > not appear to offer some sort of interrupt on data

[PATCH 2/2] ti-adc081c: Initial triggered buffer support

2016-03-31 Thread Crestez Dan Leonard
Using this requires software triggers like CONFIG_IIO_HRTIMER_TRIGGER. The device can be configured to do internal periodic sampling but does not appear to offer some sort of interrupt on data ready. It only offers interrupts on values out of a specific range. Signed-off-by: Crestez Dan Leonard