Re: [PATCH 2/2] staging: lustre: lov: remove always false condition

2015-09-08 Thread Sudip Mukherjee
On Tue, Sep 08, 2015 at 09:53:09AM -0700, Joe Perches wrote: > On Tue, 2015-09-08 at 21:53 +0530, Sudip Mukherjee wrote: > > if (qctl->qc_valid == QC_OSTIDX) { > > - if (qctl->qc_idx < 0 || count <= qctl->qc_idx) > > + if (count <= qctl->qc_idx) > >

Re: [PATCH 2/2] staging: lustre: lov: remove always false condition

2015-09-08 Thread Joe Perches
On Tue, 2015-09-08 at 21:53 +0530, Sudip Mukherjee wrote: > The member qc_idx of struct if_quotactl is unsigned and hence it can > never be less than zero. [] > diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c > b/drivers/staging/lustre/lustre/lov/lov_obd.c [] > @@ -1487,7 +1487,7 @@ stati

[PATCH 2/2] staging: lustre: lov: remove always false condition

2015-09-08 Thread Sudip Mukherjee
The member qc_idx of struct if_quotactl is unsigned and hence it can never be less than zero. Signed-off-by: Sudip Mukherjee --- drivers/staging/lustre/lustre/lov/lov_obd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c b/drivers/