Re: [PATCH 2/2] spi: convert drivers to use bits_per_word_mask

2013-07-09 Thread Mark Brown
On Tue, Jul 09, 2013 at 10:49:10PM +0100, Mark Brown wrote: > On Tue, Jul 09, 2013 at 05:47:04PM +0200, Michal Simek wrote: > > > Probably the best solution is just revert this part of patch. > > Mark: What do you think? > > We should make it so that the user does not need to supply empty > funct

Re: [PATCH 2/2] spi: convert drivers to use bits_per_word_mask

2013-07-09 Thread Mark Brown
On Tue, Jul 09, 2013 at 05:47:04PM +0200, Michal Simek wrote: > Probably the best solution is just revert this part of patch. > Mark: What do you think? We should make it so that the user does not need to supply empty functions if none are needed. signature.asc Description: Digital signature

Re: [PATCH 2/2] spi: convert drivers to use bits_per_word_mask

2013-07-09 Thread Stephen Warren
On 07/09/2013 09:47 AM, Michal Simek wrote: >> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c >> index e1d7696..f321bf9 100644 --- a/drivers/spi/spi-xilinx.c +++ >> b/drivers/spi/spi-xilinx.c @@ -232,21 +232,6 @@ static int >> xilinx_spi_setup_transfer(struct spi_device *spi, ret

Re: [PATCH 2/2] spi: convert drivers to use bits_per_word_mask

2013-07-09 Thread Michal Simek
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c > index e1d7696..f321bf9 100644 > --- a/drivers/spi/spi-xilinx.c > +++ b/drivers/spi/spi-xilinx.c > @@ -232,21 +232,6 @@ static int xilinx_spi_setup_transfer(struct spi_device > *spi, > return 0; > } > > -static int xilinx

Re: [PATCH 2/2] spi: convert drivers to use bits_per_word_mask

2013-05-31 Thread Arnd Bergmann
On Friday 31 May 2013, Stephen Warren wrote: > > drivers/spi/spi-pxa2xx.c: In function 'pxa2xx_spi_probe': > > drivers/spi/spi-pxa2xx.c:1152:3: warning: left shift count >= width of type > > [enabled by default] > >master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32); > >^ > > That shou

Re: [PATCH 2/2] spi: convert drivers to use bits_per_word_mask

2013-05-31 Thread Stephen Warren
On 05/31/2013 02:45 AM, Arnd Bergmann wrote: > Can you check this part again: > > On Tuesday 21 May 2013 20:36:35 Stephen Warren wrote: >> diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c ... >> @@ -1190,11 +1172,13 @@ static int pxa2xx_spi_probe(struct platform_device >> *pdev) >

Re: [PATCH 2/2] spi: convert drivers to use bits_per_word_mask

2013-05-31 Thread Arnd Bergmann
Can you check this part again: On Tuesday 21 May 2013 20:36:35 Stephen Warren wrote: > diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c > index f5d84d6..7de2ca1 100644 > --- a/drivers/spi/spi-pxa2xx.c > +++ b/drivers/spi/spi-pxa2xx.c > @@ -881,21 +881,6 @@ static int setup(struct s

Re: [PATCH 2/2] spi: convert drivers to use bits_per_word_mask

2013-05-29 Thread Mark Brown
On Tue, May 21, 2013 at 08:36:35PM -0600, Stephen Warren wrote: > Fill in the recently added spi_master.bits_per_word_mask field in as > many drivers as possible. Make related cleanups, such as removing any > redundant error-checking, or empty setup callbacks. Applied, thanks. signature.asc Desc

RE: [PATCH 2/2] spi: convert drivers to use bits_per_word_mask

2013-05-24 Thread H Hartley Sweeten
On Tuesday, May 21, 2013 7:37 PM, Stephen Warren wrote: > > Fill in the recently added spi_master.bits_per_word_mask field in as > many drivers as possible. Make related cleanups, such as removing any > redundant error-checking, or empty setup callbacks. > > Cc: device-drivers-de...@blackfin.uclinu

[PATCH 2/2] spi: convert drivers to use bits_per_word_mask

2013-05-21 Thread Stephen Warren
Fill in the recently added spi_master.bits_per_word_mask field in as many drivers as possible. Make related cleanups, such as removing any redundant error-checking, or empty setup callbacks. Cc: device-drivers-de...@blackfin.uclinux.org Cc: Mike Frysinger Signed-off-by: Stephen Warren --- The on