Re: [PATCH 2/2] soc: qcom: ipcc: Add support for IPCC controller

2020-05-03 Thread Manivannan Sadhasivam
On Thu, Apr 30, 2020 at 01:18:07PM -0700, Bjorn Andersson wrote: > On Wed 29 Apr 23:30 PDT 2020, Manivannan Sadhasivam wrote: > > > From: Venkata Narendra Kumar Gutta > > > > Add support for the Inter-Processor Communication Controller (IPCC) > > driver that coordinates the interrupts (inbound &

Re: [PATCH 2/2] soc: qcom: ipcc: Add support for IPCC controller

2020-04-30 Thread Bjorn Andersson
On Wed 29 Apr 23:30 PDT 2020, Manivannan Sadhasivam wrote: > From: Venkata Narendra Kumar Gutta > > Add support for the Inter-Processor Communication Controller (IPCC) > driver that coordinates the interrupts (inbound & outbound) for > Multiprocessor (MPROC), COMPUTE-Level0 (COMPUTE-L0) & COMPUT

Re: [PATCH 2/2] soc: qcom: ipcc: Add support for IPCC controller

2020-04-30 Thread Manivannan Sadhasivam
On Thu, Apr 30, 2020 at 02:53:58PM +0530, Vinod Koul wrote: > On 30-04-20, 14:32, Manivannan Sadhasivam wrote: > > Hi, > > > > On Thu, Apr 30, 2020 at 12:54:48PM +0530, Vinod Koul wrote: > > > On 30-04-20, 12:00, Manivannan Sadhasivam wrote: > > > > > > > +#define IPCC_SIGNAL_ID_MASKG

Re: [PATCH 2/2] soc: qcom: ipcc: Add support for IPCC controller

2020-04-30 Thread Vinod Koul
On 30-04-20, 14:32, Manivannan Sadhasivam wrote: > Hi, > > On Thu, Apr 30, 2020 at 12:54:48PM +0530, Vinod Koul wrote: > > On 30-04-20, 12:00, Manivannan Sadhasivam wrote: > > > > > +#define IPCC_SIGNAL_ID_MASK GENMASK(15, 0) > > > +#define IPCC_CLIENT_ID_MASK GENMASK(31

Re: [PATCH 2/2] soc: qcom: ipcc: Add support for IPCC controller

2020-04-30 Thread Manivannan Sadhasivam
Hi, On Thu, Apr 30, 2020 at 12:54:48PM +0530, Vinod Koul wrote: > On 30-04-20, 12:00, Manivannan Sadhasivam wrote: > > > +#define IPCC_SIGNAL_ID_MASKGENMASK(15, 0) > > +#define IPCC_CLIENT_ID_MASKGENMASK(31, 16) > > +#define IPCC_CLIENT_ID_SHIFT 16 >

Re: [PATCH 2/2] soc: qcom: ipcc: Add support for IPCC controller

2020-04-30 Thread Manivannan Sadhasivam
Hi, On Wed, Apr 29, 2020 at 11:45:27PM -0700, rana...@codeaurora.org wrote: > On 2020-04-29 23:30, Manivannan Sadhasivam wrote: > > +static int qcom_ipcc_probe(struct platform_device *pdev) > > +{ > > + struct qcom_ipcc_proto_data *proto_data; > > + int ret; > > + > > + proto_data = devm_kza

Re: [PATCH 2/2] soc: qcom: ipcc: Add support for IPCC controller

2020-04-30 Thread Vinod Koul
On 30-04-20, 12:00, Manivannan Sadhasivam wrote: > +#define IPCC_SIGNAL_ID_MASK GENMASK(15, 0) > +#define IPCC_CLIENT_ID_MASK GENMASK(31, 16) > +#define IPCC_CLIENT_ID_SHIFT 16 > + > +#define IPCC_NO_PENDING_IRQ 0x Why not GENMASK(31, 0) > +static struc

Re: [PATCH 2/2] soc: qcom: ipcc: Add support for IPCC controller

2020-04-29 Thread rananta
On 2020-04-29 23:30, Manivannan Sadhasivam wrote: +static int qcom_ipcc_probe(struct platform_device *pdev) +{ + struct qcom_ipcc_proto_data *proto_data; + int ret; + + proto_data = devm_kzalloc(&pdev->dev, sizeof(*proto_data), GFP_KERNEL); + if (!proto_data) + r

[PATCH 2/2] soc: qcom: ipcc: Add support for IPCC controller

2020-04-29 Thread Manivannan Sadhasivam
From: Venkata Narendra Kumar Gutta Add support for the Inter-Processor Communication Controller (IPCC) driver that coordinates the interrupts (inbound & outbound) for Multiprocessor (MPROC), COMPUTE-Level0 (COMPUTE-L0) & COMPUTE-Level1 (COMPUTE-L1) protocols for the Application Processor Subsyste