Hi Laura,
While the patch itself does what it says, the return code for the
si2157_init will be 0 even if there's a faulty firmware file. Wouldn't
it be better to set the return code as -EINVAL like done a few lines
earlier in the code (see below)?
if (fw->size % 17 != 0) {
On 10/05/2015 03:24 PM, Olli Salonen wrote:
Hi Laura,
While the patch itself does what it says, the return code for the
si2157_init will be 0 even if there's a faulty firmware file. Wouldn't
it be better to set the return code as -EINVAL like done a few lines
earlier in the code (see below)?
When reading the firmware and sending commands, the length
must be bounds checked to avoid overrunning the size of the command
buffer and smashing the stack if the firmware is not in the
expected format. Add the proper check.
Cc: sta...@kernel.org
Signed-off-by: Laura Abbott
---
drivers/media/tu
3 matches
Mail list logo
