Re: [PATCH 2/2] printk: Make the console flush configurable in hotplug path

2020-09-30 Thread Petr Mladek
On Sun 2020-09-27 19:05:34, psoda...@codeaurora.org wrote: > Yes. I agree with you that there are other conditions, which could delay the > hotplug operation. But this console > flushing is not needed in the hotplug path. In the hotplug path, a core is > trying printing messages > from other core(

Re: [PATCH 2/2] printk: Make the console flush configurable in hotplug path

2020-09-30 Thread Petr Mladek
On Wed 2020-09-23 17:08:32, Prasad Sodagudi wrote: > From: Mohammed Khajapasha > > The thread which initiates the hot plug can get scheduled > out, while trying to acquire the console lock, > thus increasing the hot plug latency. This option > allows to selectively disable the console flush and >

Re: [PATCH 2/2] printk: Make the console flush configurable in hotplug path

2020-09-28 Thread Greg KH
On Sun, Sep 27, 2020 at 07:05:34PM -0700, psoda...@codeaurora.org wrote: > On 2020-09-24 11:21, Thomas Gleixner wrote: > > On Thu, Sep 24 2020 at 08:33, Greg KH wrote: > > > On Wed, Sep 23, 2020 at 05:08:32PM -0700, Prasad Sodagudi wrote: > > > > +config CONSOLE_FLUSH_ON_HOTPLUG > > > > + boo

Re: [PATCH 2/2] printk: Make the console flush configurable in hotplug path

2020-09-27 Thread psodagud
On 2020-09-24 11:21, Thomas Gleixner wrote: On Thu, Sep 24 2020 at 08:33, Greg KH wrote: On Wed, Sep 23, 2020 at 05:08:32PM -0700, Prasad Sodagudi wrote: +config CONSOLE_FLUSH_ON_HOTPLUG + bool "Enable console flush configurable in hot plug code path" + depends on HOTPLUG_CPU +

Re: [PATCH 2/2] printk: Make the console flush configurable in hotplug path

2020-09-25 Thread Thomas Gleixner
On Fri, Sep 25 2020 at 16:16, Adam Borowski wrote: > On Fri, Sep 25, 2020 at 11:27:54AM +0200, Greg KH wrote: >> On Thu, Sep 24, 2020 at 08:21:07PM +0200, Thomas Gleixner wrote: >> > On Thu, Sep 24 2020 at 08:33, Greg KH wrote: >> > > On Wed, Sep 23, 2020 at 05:08:32PM -0700, Prasad Sodagudi wrote:

Re: [PATCH 2/2] printk: Make the console flush configurable in hotplug path

2020-09-25 Thread Adam Borowski
On Fri, Sep 25, 2020 at 11:27:54AM +0200, Greg KH wrote: > On Thu, Sep 24, 2020 at 08:21:07PM +0200, Thomas Gleixner wrote: > > On Thu, Sep 24 2020 at 08:33, Greg KH wrote: > > > On Wed, Sep 23, 2020 at 05:08:32PM -0700, Prasad Sodagudi wrote: > > >> +config CONSOLE_FLUSH_ON_HOTPLUG > > >> +

Re: [PATCH 2/2] printk: Make the console flush configurable in hotplug path

2020-09-25 Thread Greg KH
On Thu, Sep 24, 2020 at 08:21:07PM +0200, Thomas Gleixner wrote: > On Thu, Sep 24 2020 at 08:33, Greg KH wrote: > > On Wed, Sep 23, 2020 at 05:08:32PM -0700, Prasad Sodagudi wrote: > >> +config CONSOLE_FLUSH_ON_HOTPLUG > >> + bool "Enable console flush configurable in hot plug code path" > >> + d

Re: [PATCH 2/2] printk: Make the console flush configurable in hotplug path

2020-09-24 Thread Thomas Gleixner
On Thu, Sep 24 2020 at 08:33, Greg KH wrote: > On Wed, Sep 23, 2020 at 05:08:32PM -0700, Prasad Sodagudi wrote: >> +config CONSOLE_FLUSH_ON_HOTPLUG >> +bool "Enable console flush configurable in hot plug code path" >> +depends on HOTPLUG_CPU >> +def_bool n > > n is the default, no need

Re: [PATCH 2/2] printk: Make the console flush configurable in hotplug path

2020-09-23 Thread Sergey Senozhatsky
On (20/09/23 17:08), Prasad Sodagudi wrote: > From: Mohammed Khajapasha > > The thread which initiates the hot plug can get scheduled > out, while trying to acquire the console lock, > thus increasing the hot plug latency. This option > allows to selectively disable the console flush and > in tur

Re: [PATCH 2/2] printk: Make the console flush configurable in hotplug path

2020-09-23 Thread Greg KH
On Wed, Sep 23, 2020 at 05:08:32PM -0700, Prasad Sodagudi wrote: > From: Mohammed Khajapasha > > The thread which initiates the hot plug can get scheduled > out, while trying to acquire the console lock, > thus increasing the hot plug latency. This option > allows to selectively disable the conso

[PATCH 2/2] printk: Make the console flush configurable in hotplug path

2020-09-23 Thread Prasad Sodagudi
From: Mohammed Khajapasha The thread which initiates the hot plug can get scheduled out, while trying to acquire the console lock, thus increasing the hot plug latency. This option allows to selectively disable the console flush and in turn reduce the hot plug latency. Signed-off-by: Mohammed Kh