Re: [PATCH 2/2] powernv: Pass PSSCR value and mask to power9_idle_stop

2016-10-13 Thread Gautham R Shenoy
Hi Stewart, On Wed, Oct 12, 2016 at 04:35:35PM +1100, Stewart Smith wrote: > > What if we just treat the 0xF state from firmware as special and set it > to DEFAULT_PSSCR_MASK in that case? That deals with old skiboot, new > kernel, and sets a pretty small special case that's easy to track into >

Re: [PATCH 2/2] powernv: Pass PSSCR value and mask to power9_idle_stop

2016-10-12 Thread Stewart Smith
Gautham R Shenoy writes: > On Tue, Oct 04, 2016 at 10:33:27PM +1100, Balbir Singh wrote: >> >> >> On 04/10/16 21:32, Michael Ellerman wrote: >> > "Gautham R. Shenoy" writes: >> > >> >> From: "Gautham R. Shenoy" >> >> >> >> The power9_idle_stop method currently takes only the requested stop >>

Re: [PATCH 2/2] powernv: Pass PSSCR value and mask to power9_idle_stop

2016-10-07 Thread Gautham R Shenoy
Hi Balbir, Michael, On Tue, Oct 04, 2016 at 10:33:27PM +1100, Balbir Singh wrote: > > > On 04/10/16 21:32, Michael Ellerman wrote: > > "Gautham R. Shenoy" writes: > > > >> From: "Gautham R. Shenoy" > >> > >> The power9_idle_stop method currently takes only the requested stop > >> level as a

Re: [PATCH 2/2] powernv: Pass PSSCR value and mask to power9_idle_stop

2016-10-04 Thread Balbir Singh
On 04/10/16 21:32, Michael Ellerman wrote: > "Gautham R. Shenoy" writes: > >> From: "Gautham R. Shenoy" >> >> The power9_idle_stop method currently takes only the requested stop >> level as a parameter and picks up the rest of the PSSCR bits from a >> hand-coded macro. This is not a very flexi

[PATCH 2/2] powernv: Pass PSSCR value and mask to power9_idle_stop

2016-09-29 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" The power9_idle_stop method currently takes only the requested stop level as a parameter and picks up the rest of the PSSCR bits from a hand-coded macro. This is not a very flexible design, especially when the firmware has the capability to communicate the psscr value an