Re: [PATCH 2/2] pm: allow drivers to drop #ifdef and __maybe_unused from pm callbacks

2021-04-08 Thread Masahiro Yamada
On Fri, Apr 9, 2021 at 6:30 AM Arnd Bergmann wrote: > > On Thu, Apr 8, 2021 at 11:00 PM Masahiro Yamada wrote: > > > > Drivers typically surround suspend and resume callbacks with #ifdef > > CONFIG_PM(_SLEEP) or mark them as __maybe_unused in order to avoid > > -Wunused-const-variable warnings. >

Re: [PATCH 2/2] pm: allow drivers to drop #ifdef and __maybe_unused from pm callbacks

2021-04-08 Thread kernel test robot
Hi Masahiro, I love your patch! Yet something to improve: [auto build test ERROR on pinctrl/devel] [also build test ERROR on pm/linux-next soc/for-next linus/master v5.12-rc6] [cannot apply to next-20210408] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitti

Re: [PATCH 2/2] pm: allow drivers to drop #ifdef and __maybe_unused from pm callbacks

2021-04-08 Thread kernel test robot
Hi Masahiro, I love your patch! Yet something to improve: [auto build test ERROR on pinctrl/devel] [also build test ERROR on pm/linux-next soc/for-next linus/master v5.12-rc6] [cannot apply to next-20210408] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitti

Re: [PATCH 2/2] pm: allow drivers to drop #ifdef and __maybe_unused from pm callbacks

2021-04-08 Thread Arnd Bergmann
On Thu, Apr 8, 2021 at 11:00 PM Masahiro Yamada wrote: > > Drivers typically surround suspend and resume callbacks with #ifdef > CONFIG_PM(_SLEEP) or mark them as __maybe_unused in order to avoid > -Wunused-const-variable warnings. > > With this commit, drivers will be able to remove #ifdef CONFIG

[PATCH 2/2] pm: allow drivers to drop #ifdef and __maybe_unused from pm callbacks

2021-04-08 Thread Masahiro Yamada
Drivers typically surround suspend and resume callbacks with #ifdef CONFIG_PM(_SLEEP) or mark them as __maybe_unused in order to avoid -Wunused-const-variable warnings. With this commit, drivers will be able to remove #ifdef CONFIG_PM(_SLEEP) and __maybe_unsed because unused functions are dropped