Re: [PATCH 2/2] perf trace: Fix segmentfault on perf trace

2015-05-11 Thread Arnaldo Carvalho de Melo
Em Mon, May 11, 2015 at 10:47:34AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, May 11, 2015 at 08:11:14PM +0800, He Kuang escreveu: > > >So we can either do the check outside > > >builtin-trace.c:perf_evlist__mmap_read() like what > > >builtin-record.c do or inside. What's your opinion? > >

Re: [PATCH 2/2] perf trace: Fix segmentfault on perf trace

2015-05-11 Thread Arnaldo Carvalho de Melo
Em Mon, May 11, 2015 at 08:11:14PM +0800, He Kuang escreveu: > Hi, Arnaldo > > On 2015/4/8 11:15, He Kuang wrote: > >Hi, Arnaldo > >On 2015/4/7 20:36, Arnaldo Carvalho de Melo wrote: > >>Em Tue, Apr 07, 2015 at 05:31:11PM +0800, He Kuang escreveu: > >>>After perf_evlist__filter_pollfd() filters ou

Re: [PATCH 2/2] perf trace: Fix segmentfault on perf trace

2015-05-11 Thread He Kuang
Hi, Arnaldo On 2015/4/8 11:15, He Kuang wrote: Hi, Arnaldo On 2015/4/7 20:36, Arnaldo Carvalho de Melo wrote: Em Tue, Apr 07, 2015 at 05:31:11PM +0800, He Kuang escreveu: After perf_evlist__filter_pollfd() filters out fds and releases perf_mmap by using perf_evlist__mmap_put(), refcnt of perf_

Re: [PATCH 2/2] perf trace: Fix segmentfault on perf trace

2015-04-07 Thread He Kuang
Hi, Arnaldo On 2015/4/7 20:36, Arnaldo Carvalho de Melo wrote: Em Tue, Apr 07, 2015 at 05:31:11PM +0800, He Kuang escreveu: After perf_evlist__filter_pollfd() filters out fds and releases perf_mmap by using perf_evlist__mmap_put(), refcnt of perf_mmap hits 1 then perf_evlist__mmap_consume() will

Re: [PATCH 2/2] perf trace: Fix segmentfault on perf trace

2015-04-07 Thread Arnaldo Carvalho de Melo
Em Tue, Apr 07, 2015 at 05:31:11PM +0800, He Kuang escreveu: > After perf_evlist__filter_pollfd() filters out fds and releases > perf_mmap by using perf_evlist__mmap_put(), refcnt of perf_mmap hits 1 > then perf_evlist__mmap_consume() will do the final unmap. In this > condition, perf_evlist__mmap_

[PATCH 2/2] perf trace: Fix segmentfault on perf trace

2015-04-07 Thread He Kuang
After perf_evlist__filter_pollfd() filters out fds and releases perf_mmap by using perf_evlist__mmap_put(), refcnt of perf_mmap hits 1 then perf_evlist__mmap_consume() will do the final unmap. In this condition, perf_evlist__mmap_read() will crash by referencing invalid mmap. Put refcnt check befor