Re: [PATCH 2/2] perf trace: Fix segfault on perf trace -i perf.data

2013-11-12 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 12, 2013 at 09:27:23PM +, Namhyung Kim escreveu: > Hi Arnaldo, > > On Tue, Nov 12, 2013 at 08:57:00AM -0300, Arnaldo Carvalho de Melo wrote: > > So this becomes the first part of this patch, split from yours and > > massaged a bit so that by looking at the patch it becomes quickly

Re: [PATCH 2/2] perf trace: Fix segfault on perf trace -i perf.data

2013-11-12 Thread Namhyung Kim
On Tue, Nov 12, 2013 at 09:15:08AM -0300, Arnaldo Carvalho de Melo wrote: > Second part, just rewrote the changelog a bit: > > commit 4e8a6e566fc611b9cbec2978a52266f29cb65785 > Author: Namhyung Kim > Date: Tue Nov 12 15:25:00 2013 +0900 > > perf trace: Fix segfault on perf trace -i perf.da

Re: [PATCH 2/2] perf trace: Fix segfault on perf trace -i perf.data

2013-11-12 Thread Namhyung Kim
Hi Arnaldo, On Tue, Nov 12, 2013 at 08:57:00AM -0300, Arnaldo Carvalho de Melo wrote: > So this becomes the first part of this patch, split from yours and > massaged a bit so that by looking at the patch it becomes quickly clear > what it is doing, please let me now if I can keep this as-is (with

Re: [PATCH 2/2] perf trace: Fix segfault on perf trace -i perf.data

2013-11-12 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 12, 2013 at 08:57:00AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Nov 12, 2013 at 08:46:09AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Tue, Nov 12, 2013 at 03:25:00PM +0900, Namhyung Kim escreveu: > > > From: Namhyung Kim > > > > When replaying a previous record sessio

Re: [PATCH 2/2] perf trace: Fix segfault on perf trace -i perf.data

2013-11-12 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 12, 2013 at 08:46:09AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Nov 12, 2013 at 03:25:00PM +0900, Namhyung Kim escreveu: > > From: Namhyung Kim > > When replaying a previous record session, it'll get a segfault since > > it doesn't initialize evsel->priv for finding syscall

Re: [PATCH 2/2] perf trace: Fix segfault on perf trace -i perf.data

2013-11-12 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 12, 2013 at 03:25:00PM +0900, Namhyung Kim escreveu: > From: Namhyung Kim > > When replaying a previous record session, it'll get a segfault since > it doesn't initialize evsel->priv for finding syscall id. So fix it > by initialize sys_enter/exit evsel manually. > > While at it, fa

[PATCH 2/2] perf trace: Fix segfault on perf trace -i perf.data

2013-11-11 Thread Namhyung Kim
From: Namhyung Kim When replaying a previous record session, it'll get a segfault since it doesn't initialize evsel->priv for finding syscall id. So fix it by initialize sys_enter/exit evsel manually. While at it, factor out perf_evsel__init_syscall_tp() to init a syscall evsel and remove unuse