Re: [PATCH 2/2] media: dvb-usb: Fix use-after-free access

2021-02-01 Thread Takashi Iwai
On Sun, 31 Jan 2021 16:04:56 +0100, Sean Young wrote: > > Hi Takashi, > > On Fri, Jan 22, 2021 at 04:47:44PM +0100, Robert Foss wrote: > > Hey Takashi, > > > > This patch is generating a checkpatch warning, but I think it is > > spurious and can be ignored. > > The checkpatch warning isn't supe

Re: [PATCH 2/2] media: dvb-usb: Fix use-after-free access

2021-01-31 Thread Sean Young
Hi Takashi, On Fri, Jan 22, 2021 at 04:47:44PM +0100, Robert Foss wrote: > Hey Takashi, > > This patch is generating a checkpatch warning, but I think it is > spurious and can be ignored. The checkpatch warning isn't superious and should really be corrected. > > Other than that, this looks goo

Re: [PATCH 2/2] media: dvb-usb: Fix use-after-free access

2021-01-22 Thread Robert Foss
Hey Takashi, This patch is generating a checkpatch warning, but I think it is spurious and can be ignored. Other than that, this looks good to me. Reviewed-by: Robert Foss On Wed, 20 Jan 2021 at 12:51, Takashi Iwai wrote: > > dvb_usb_device_init() copies the properties to the own data, so that

[PATCH 2/2] media: dvb-usb: Fix use-after-free access

2021-01-20 Thread Takashi Iwai
dvb_usb_device_init() copies the properties to the own data, so that the callers can release the original properties later (as done in the commit 299c7007e936 "media: dw2102: Fix memleak on sequence of probes"). However, it also stores dev->desc pointer that is a reference to the original properti