Re: [PATCH 2/2] mach-spear: fixed spear1340.c file

2014-07-03 Thread Viresh Kumar
Hi Nick, On Fri, Jul 4, 2014 at 2:07 AM, Nick Krause wrote: > Very well then I will read the documentation on Kconfig in order to > understand that and fix up my patches for that. > On the other hand I will send a email before the patches to tell in > what order to apply them. As already asked b

Re: [PATCH 2/2] mach-spear: fixed spear1340.c file

2014-07-03 Thread Nick Krause
Very well then I will read the documentation on Kconfig in order to understand that and fix up my patches for that. On the other hand I will send a email before the patches to tell in what order to apply them. Cheers Nick On Thu, Jul 3, 2014 at 2:36 PM, Paul Bolle wrote: > [I fixed the top postin

Re: [PATCH 2/2] mach-spear: fixed spear1340.c file

2014-07-03 Thread Paul Bolle
[I fixed the top posting.] On Thu, 2014-07-03 at 14:08 -0400, Nick Krause wrote: > On Thu, Jul 3, 2014 at 2:04 PM, Paul Bolle wrote: > > This patch, together with patch 1/2, basically moves a chunk of code > > into a separate file, didn't it? If so, why did you split that move in > > two patches?

Re: [PATCH 2/2] mach-spear: fixed spear1340.c file

2014-07-03 Thread Nick Krause
Yes it is and I did it in two patches in order to be more readable. Furthermore I don't known Kconfig well enough to do the Makefile for the file I created. Cheers Nick On Thu, Jul 3, 2014 at 2:04 PM, Paul Bolle wrote: > On Wed, 2014-07-02 at 22:36 -0400, Nicholas Krause wrote: >> This is the fix

Re: [PATCH 2/2] mach-spear: fixed spear1340.c file

2014-07-03 Thread Paul Bolle
On Wed, 2014-07-02 at 22:36 -0400, Nicholas Krause wrote: > This is the fixed file after moving sata support to new file in > spear1340_sata.c > > Signed-off-by: Nicholas Krause > --- > arch/arm/mach-spear/spear1340.c | 111 > > 1 file changed, 111 delet

[PATCH 2/2] mach-spear: fixed spear1340.c file

2014-07-02 Thread Nicholas Krause
This is the fixed file after moving sata support to new file in spear1340_sata.c Signed-off-by: Nicholas Krause --- arch/arm/mach-spear/spear1340.c | 111 1 file changed, 111 deletions(-) diff --git a/arch/arm/mach-spear/spear1340.c b/arch/arm/mach-spear