Re: [PATCH 2/2] locking/mutex: Use mutex flags macro instead of hard code value

2019-07-30 Thread Mukesh Ojha
On 7/30/2019 9:32 PM, Peter Zijlstra wrote: On Tue, Jul 30, 2019 at 06:10:49PM +0530, Mukesh Ojha wrote: To make it static , i have to export mutex_is_locked() after moving it inside mutex.c, so that other module can use it. Yep, see below -- completely untested. Also are we thinking of re

Re: [PATCH 2/2] locking/mutex: Use mutex flags macro instead of hard code value

2019-07-30 Thread Peter Zijlstra
On Tue, Jul 30, 2019 at 06:10:49PM +0530, Mukesh Ojha wrote: > To make it static , i have to export mutex_is_locked() after moving it > inside mutex.c, so that other module can use it. Yep, see below -- completely untested. > Also are we thinking of removing > static inline /* __deprecated */ __

Re: [PATCH 2/2] locking/mutex: Use mutex flags macro instead of hard code value

2019-07-30 Thread Mukesh Ojha
On 7/30/2019 1:33 PM, Peter Zijlstra wrote: On Tue, Jul 30, 2019 at 01:23:13PM +0530, Mukesh Ojha wrote: On 7/29/2019 4:37 PM, Peter Zijlstra wrote: On Mon, Jul 29, 2019 at 04:22:58PM +0530, Mukesh Ojha wrote: Let's use the mutex flag macro(which got moved from mutex.c to linux/mutex.h in th

Re: [PATCH 2/2] locking/mutex: Use mutex flags macro instead of hard code value

2019-07-30 Thread Peter Zijlstra
On Tue, Jul 30, 2019 at 01:23:13PM +0530, Mukesh Ojha wrote: > > On 7/29/2019 4:37 PM, Peter Zijlstra wrote: > > On Mon, Jul 29, 2019 at 04:22:58PM +0530, Mukesh Ojha wrote: > > > Let's use the mutex flag macro(which got moved from mutex.c > > > to linux/mutex.h in the last patch) instead of hard

Re: [PATCH 2/2] locking/mutex: Use mutex flags macro instead of hard code value

2019-07-30 Thread Mukesh Ojha
On 7/29/2019 4:37 PM, Peter Zijlstra wrote: On Mon, Jul 29, 2019 at 04:22:58PM +0530, Mukesh Ojha wrote: Let's use the mutex flag macro(which got moved from mutex.c to linux/mutex.h in the last patch) instead of hard code value which was used in __mutex_owner(). Signed-off-by: Mukesh Ojha --

Re: [PATCH 2/2] locking/mutex: Use mutex flags macro instead of hard code value

2019-07-29 Thread Peter Zijlstra
On Mon, Jul 29, 2019 at 04:22:58PM +0530, Mukesh Ojha wrote: > Let's use the mutex flag macro(which got moved from mutex.c > to linux/mutex.h in the last patch) instead of hard code > value which was used in __mutex_owner(). > > Signed-off-by: Mukesh Ojha > --- > include/linux/mutex.h | 2 +- >

[PATCH 2/2] locking/mutex: Use mutex flags macro instead of hard code value

2019-07-29 Thread Mukesh Ojha
Let's use the mutex flag macro(which got moved from mutex.c to linux/mutex.h in the last patch) instead of hard code value which was used in __mutex_owner(). Signed-off-by: Mukesh Ojha --- include/linux/mutex.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mut