Re: [PATCH 2/2] kernel: sched: fix preempt_disable_ip recodring for preempt_disable()

2016-02-12 Thread Steven Rostedt
On Fri, 12 Feb 2016 16:21:53 +0100 Sebastian Andrzej Siewior wrote: > On 02/12/2016 01:45 AM, Steven Rostedt wrote: > > Looks like you need to add this? (maybe) > > no. It will then try to include other files and complain even more. > I've sent v2 and drop this split and looks simpler now. >

Re: [PATCH 2/2] kernel: sched: fix preempt_disable_ip recodring for preempt_disable()

2016-02-12 Thread Sebastian Andrzej Siewior
On 02/12/2016 01:45 AM, Steven Rostedt wrote: > Looks like you need to add this? (maybe) no. It will then try to include other files and complain even more. I've sent v2 and drop this split and looks simpler now. > -- Steve Sebastian

Re: [PATCH 2/2] kernel: sched: fix preempt_disable_ip recodring for preempt_disable()

2016-02-11 Thread Steven Rostedt
On Fri, 12 Feb 2016 08:27:01 +0800 kbuild test robot wrote: > Hi Sebastian, > > [auto build test ERROR on tip/sched/core] > [also build test ERROR on v4.5-rc3 next-20160211] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > Gotta love W

Re: [PATCH 2/2] kernel: sched: fix preempt_disable_ip recodring for preempt_disable()

2016-02-11 Thread kbuild test robot
Hi Sebastian, [auto build test ERROR on tip/sched/core] [also build test ERROR on v4.5-rc3 next-20160211] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Sebastian-Andrzej-Siewior/ftrace-move-t

Re: [PATCH 2/2] kernel: sched: fix preempt_disable_ip recodring for preempt_disable()

2016-02-11 Thread Sebastian Andrzej Siewior
Before: preempt_test(1) kernel_init_freeable+0x1bd/0x239 preempt_test(2) preempt_test+0x75/0x15c preempt_test(3) preempt_test+0xaa/0x15c preempt_test(4) kernel_init_freeable+0x1bd/0x239 preempt_test(5) kernel_init_freeable+0x1bd/0x239 After: preempt_test(1) preempt_test+0x2f/0x15c preempt_t

[PATCH 2/2] kernel: sched: fix preempt_disable_ip recodring for preempt_disable()

2016-02-11 Thread Sebastian Andrzej Siewior
The preempt_disable() invokes preempt_count_add() which saves the caller in ->preempt_disable_ip. It uses CALLER_ADDR1 which does not look for its caller but for the parent of the caller. Which means we get the correct caller for something like spin_lock() unless the architectures inlines those inv