Re: [PATCH 2/2] iwlwifi: add power management support -v2

2007-11-26 Thread Tomas Winkler
> > At some point everyone needs to standardize on power levels so that > userland has a hope of mapping the right state to the right power level > in the driver. Otherwise, we get into a situation where broadcom power > levels don't map the same way iwl powerlevels do, and then we can't ever > do

Re: [PATCH 2/2] iwlwifi: add power management support -v2

2007-11-26 Thread Dan Williams
On Mon, 2007-11-26 at 19:11 +0200, Tomas Winkler wrote: > On Nov 26, 2007 6:18 PM, Miguel Botón <[EMAIL PROTECTED]> wrote: > > > > On Saturday 17 November 2007 07:15:05 Tomas Winkler wrote: > > > Why power management shouldn't be enabled while in AC? The semantic of > > > this > > > ioctls is quit

Re: [PATCH 2/2] iwlwifi: add power management support -v2

2007-11-26 Thread Tomas Winkler
On Nov 26, 2007 6:18 PM, Miguel Botón <[EMAIL PROTECTED]> wrote: > > On Saturday 17 November 2007 07:15:05 Tomas Winkler wrote: > > Why power management shouldn't be enabled while in AC? The semantic of this > > ioctls is quite unclear. > I > IWL_POWER_AC and IWL_POWER_BATTERY are just two power mo

Re: [PATCH 2/2] iwlwifi: add power management support -v2

2007-11-26 Thread Miguel Botón
On Saturday 17 November 2007 07:15:05 Tomas Winkler wrote: > Why power management shouldn't be enabled while in AC? The semantic of this > ioctls is quite unclear. IWL_POWER_AC and IWL_POWER_BATTERY are just two power modes. IWL_POWER_AC would be the default power mode when we're in AC (no power

[PATCH 2/2] iwlwifi: add power management support -v2

2007-11-16 Thread Miguel Botón
This patch adds power management support in iwl3945 and iwl4965 drivers. Signed-off-by: Miguel Botón <[EMAIL PROTECTED]> diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c index 9baf8de..5c7b422 100644 --- a/drivers/net/wireless/iwlwifi/iwl3945