[PATCH 2/2] input: gpio-keys: Add runtime support

2012-11-22 Thread Lee Jones
From: Jonas Aaberg Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones Signed-off-by: Jonas Aaberg Signed-off-by: Philippe Langlais Reviewed-by: Bengt Jonsson --- drivers/input/keyboard/gpio_keys.c | 17 + 1 file changed, 13 insertions(+), 4 deleti

Re: [PATCH 2/2] input: gpio-keys: Add runtime support

2012-11-22 Thread Lee Jones
Ignore this. I've just rebased and the API has changed slightly. Will fixup and resend. > From: Jonas Aaberg > > Cc: Dmitry Torokhov > Cc: linux-in...@vger.kernel.org > Signed-off-by: Lee Jones > Signed-off-by: Jonas Aaberg > Signed-off-by: Philippe Langlais > Reviewed-by: Bengt Jonsson >

Re: [PATCH 2/2] input: gpio-keys: Add runtime support

2012-10-25 Thread Lee Jones
On Thu, 25 Oct 2012, Dmitry Torokhov wrote: > On Thu, Oct 25, 2012 at 09:21:45AM +0100, Lee Jones wrote: > > On Thu, 25 Oct 2012, Linus Walleij wrote: > > > > > On Thu, Oct 25, 2012 at 9:57 AM, Lee Jones wrote: > > > > On Fri, 12 Oct 2012, Linus Walleij wrote: > > > > > > >> Yours, > > > >> Lin

Re: [PATCH 2/2] input: gpio-keys: Add runtime support

2012-10-25 Thread Dmitry Torokhov
On Thu, Oct 25, 2012 at 09:21:45AM +0100, Lee Jones wrote: > On Thu, 25 Oct 2012, Linus Walleij wrote: > > > On Thu, Oct 25, 2012 at 9:57 AM, Lee Jones wrote: > > > On Fri, 12 Oct 2012, Linus Walleij wrote: > > > > >> Yours, > > >> Linus Walleij > > > > > > Friendly poke. > > > > This makes it

Re: [PATCH 2/2] input: gpio-keys: Add runtime support

2012-10-25 Thread Lee Jones
On Thu, 25 Oct 2012, Linus Walleij wrote: > On Thu, Oct 25, 2012 at 9:57 AM, Lee Jones wrote: > > On Fri, 12 Oct 2012, Linus Walleij wrote: > > >> Yours, > >> Linus Walleij > > > > Friendly poke. > > This makes it look like you're poking me as I'm in the To: field but I suspect > the intent mus

Re: [PATCH 2/2] input: gpio-keys: Add runtime support

2012-10-25 Thread Linus Walleij
On Thu, Oct 25, 2012 at 9:57 AM, Lee Jones wrote: > On Fri, 12 Oct 2012, Linus Walleij wrote: >> Yours, >> Linus Walleij > > Friendly poke. This makes it look like you're poking me as I'm in the To: field but I suspect the intent must be to poke Dmitry ... I was just providing background for Shu

Re: [PATCH 2/2] input: gpio-keys: Add runtime support

2012-10-25 Thread Lee Jones
On Fri, 12 Oct 2012, Linus Walleij wrote: > On Thu, Oct 11, 2012 at 4:22 PM, Shubhrajyoti Datta > wrote: > > >> @@ -526,6 +527,7 @@ static int gpio_keys_open(struct input_dev *input) > >> { > >> struct gpio_keys_drvdata *ddata = input_get_drvdata(input); > >> > >> + pm_runtime_get

Re: [PATCH 2/2] input: gpio-keys: Add runtime support

2012-10-12 Thread Linus Walleij
On Thu, Oct 11, 2012 at 4:22 PM, Shubhrajyoti Datta wrote: >> @@ -526,6 +527,7 @@ static int gpio_keys_open(struct input_dev *input) >> { >> struct gpio_keys_drvdata *ddata = input_get_drvdata(input); >> >> + pm_runtime_get_sync(input->dev.parent); > > I am not an expert of the run

Re: [PATCH 2/2] input: gpio-keys: Add runtime support

2012-10-11 Thread Lee Jones
> > From: Jonas Aaberg > Some change logs would have helped. Granted. Hopefully Jonas will be happy to step forward and answer any of your following questions. > > Cc: Dmitry Torokhov > > Cc: linux-in...@vger.kernel.org > > Acked-by: Lee Jones > > Signed-off-by: Jonas Aaberg > > Signed-off-b

Re: [PATCH 2/2] input: gpio-keys: Add runtime support

2012-10-11 Thread Shubhrajyoti Datta
On Thu, Oct 11, 2012 at 7:45 PM, Lee Jones wrote: > From: Jonas Aaberg Some change logs would have helped. > > Cc: Dmitry Torokhov > Cc: linux-in...@vger.kernel.org > Acked-by: Lee Jones > Signed-off-by: Jonas Aaberg > Signed-off-by: Philippe Langlais > Reviewed-by: Bengt Jonsson > --- > d

[PATCH 2/2] input: gpio-keys: Add runtime support

2012-10-11 Thread Lee Jones
From: Jonas Aaberg Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Acked-by: Lee Jones Signed-off-by: Jonas Aaberg Signed-off-by: Philippe Langlais Reviewed-by: Bengt Jonsson --- drivers/input/keyboard/gpio_keys.c | 16 1 file changed, 12 insertions(+), 4 deletions(-)