Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-12-03 Thread Naveen Krishna Ch
On 4 December 2012 05:41, Olof Johansson wrote: > On Sat, Dec 1, 2012 at 5:26 AM, Mark Brown > wrote: >> On Thu, Nov 29, 2012 at 10:14:58PM -0800, Olof Johansson wrote: >>> On Thu, Nov 29, 2012 at 6:13 PM, Simon Glass wrote: >> >>> > It was originally done separately but I think it was felt that

Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-12-03 Thread Olof Johansson
On Sat, Dec 1, 2012 at 5:26 AM, Mark Brown wrote: > On Thu, Nov 29, 2012 at 10:14:58PM -0800, Olof Johansson wrote: >> On Thu, Nov 29, 2012 at 6:13 PM, Simon Glass wrote: > >> > It was originally done separately but I think it was felt that this >> > was overly complex. Olof can you please commen

Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-12-01 Thread Mark Brown
On Thu, Nov 29, 2012 at 10:14:58PM -0800, Olof Johansson wrote: > On Thu, Nov 29, 2012 at 6:13 PM, Simon Glass wrote: > > It was originally done separately but I think it was felt that this > > was overly complex. Olof can you please comment on this? > it is indeed not controller specific per se

Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-11-29 Thread Olof Johansson
On Thu, Nov 29, 2012 at 6:13 PM, Simon Glass wrote: > +Olof > > On Thu, Nov 29, 2012 at 8:34 AM, Mark Brown > wrote: >> On Thu, Nov 29, 2012 at 10:35:35AM +0530, Naveen Krishna Chatradhi wrote: >> >>> The arbitrator is a general purpose function which uses two GPIOs to >>> communicate with anothe

Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-11-29 Thread Simon Glass
+Olof On Thu, Nov 29, 2012 at 8:34 AM, Mark Brown wrote: > On Thu, Nov 29, 2012 at 10:35:35AM +0530, Naveen Krishna Chatradhi wrote: > >> The arbitrator is a general purpose function which uses two GPIOs to >> communicate with another device to claim/release a bus. We use it to >> arbitrate an i2

Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-11-29 Thread Mark Brown
On Thu, Nov 29, 2012 at 10:35:35AM +0530, Naveen Krishna Chatradhi wrote: > The arbitrator is a general purpose function which uses two GPIOs to > communicate with another device to claim/release a bus. We use it to > arbitrate an i2c port between the AP and the EC. Should this not be layerd on t

[PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-11-28 Thread Naveen Krishna Chatradhi
From: Simon Glass The arbitrator is a general purpose function which uses two GPIOs to communicate with another device to claim/release a bus. We use it to arbitrate an i2c port between the AP and the EC. Signed-off-by: Simon Glass Cc: Grant Grundler Signed-off-by: Naveen Krishna Chatradhi --