Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-30 Thread Paul Bolle
On Sat, 2015-03-28 at 17:55 -0700, Guenter Roeck wrote: > On 03/28/2015 03:44 PM, Paul Bolle wrote: > > I haven't actually looked into this part of the patch, since as far as > > I'm concerned this patch is broken. > > You mean beyond the "ON" and the above problem ? Can you elaborate ? No, I was

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-30 Thread Jean Delvare
On Sat, 28 Mar 2015 23:33:46 +0100, Pali Rohár wrote: > I think it would be better to locate on which bus are sensors > connected (smbus? isa? pci?), find out HW chips and wrote native > kernel drivers for them... > > I scanned smbus (intel controller connected on pci) on my E6440 > but there i

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Guenter Roeck
On 03/28/2015 03:44 PM, Paul Bolle wrote: Guenter Roeck schreef op za 28-03-2015 om 15:20 [-0700]: Maybe that is the plan, but it is not what is happening. I8K selects SENSORS_DELL_SMM, so a boolean I8K forces SENSORS_DELL_SMM to be built into the kernel. What you suggest would work if I8K woul

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Paul Bolle
Guenter Roeck schreef op za 28-03-2015 om 15:20 [-0700]: > Maybe that is the plan, but it is not what is happening. > I8K selects SENSORS_DELL_SMM, so a boolean I8K forces SENSORS_DELL_SMM > to be built into the kernel. > > What you suggest would work if I8K would depend on SENSORS_DELL_SMM, > but

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Pali Rohár
On Saturday 28 March 2015 23:19:04 Steven Honeyman wrote: > On 28 March 2015 at 22:00, Pali Rohár > wrote: > > On Saturday 28 March 2015 13:54:51 Steven Honeyman wrote: > >> i8k-virtual-0 > >> Adapter: Virtual device > >> Processor Fan: 3171 RPM > >> CPU:+52.0°C > >> Ambient:+4

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Guenter Roeck
On 03/28/2015 03:00 PM, Pali Rohár wrote: On Saturday 28 March 2015 13:54:51 Steven Honeyman wrote: On 28 March 2015 at 11:04, Paul Bolle wrote: On Sat, 2015-03-28 at 11:24 +0100, Pali Rohár wrote: --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -1703,6 +1703,17 @@ config SENSORS_

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Steven Honeyman
On 28 March 2015 at 22:00, Pali Rohár wrote: > On Saturday 28 March 2015 13:54:51 Steven Honeyman wrote: >> i8k-virtual-0 >> Adapter: Virtual device >> Processor Fan: 3171 RPM >> CPU:+52.0°C >> Ambient:+46.0°C >> SODIMM: +40.0°C >> - >> >> Ambient and SODIMM look sw

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Paul Bolle
On Sat, 2015-03-28 at 22:55 +0100, Pali Rohár wrote: > I have tested compilation only with out of tree make command with > manual CONFIG_SENSORS_DELL_SMM and CONFIG_I8K options. Not sure what you mean here. I can't get things past this error: drivers/hwmon/Kconfig:1721: syntax error drive

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Pali Rohár
On Saturday 28 March 2015 15:23:15 Guenter Roeck wrote: > > + ---help--- > > + This hwmon driver adds support for reporting temperature > > of different +sensors and controls the fans on Dell > > laptops via System Management + Mode provided by Dell > > BIOS. > > + > > + Whe

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Pali Rohár
On Saturday 28 March 2015 13:54:51 Steven Honeyman wrote: > On 28 March 2015 at 11:04, Paul Bolle wrote: > > On Sat, 2015-03-28 at 11:24 +0100, Pali Rohár wrote: > >> --- a/drivers/hwmon/Kconfig > >> +++ b/drivers/hwmon/Kconfig > >> @@ -1703,6 +1703,17 @@ config SENSORS_ULTRA45 > >> > >>

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Pali Rohár
On Saturday 28 March 2015 12:04:20 Paul Bolle wrote: > On Sat, 2015-03-28 at 11:24 +0100, Pali Rohár wrote: > > --- a/drivers/hwmon/Kconfig > > +++ b/drivers/hwmon/Kconfig > > @@ -1703,6 +1703,17 @@ config SENSORS_ULTRA45 > > > > This driver provides support for the Ultra45 workstation > >

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Guenter Roeck
On 03/28/2015 03:24 AM, Pali Rohár wrote: This patch splits CONFIG_I8K compile option to SENSORS_DELL_SMM and CONFIG_I8K. Option SENSORS_DELL_SMM is now used to enable compilation of dell-smm-hwmon driver and old CONFIG_I8K option to enable /proc/i8k interface in driver. So this change allows to

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Guenter Roeck
On 03/28/2015 05:54 AM, Steven Honeyman wrote: On 28 March 2015 at 11:04, Paul Bolle wrote: On Sat, 2015-03-28 at 11:24 +0100, Pali Rohár wrote: --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -1703,6 +1703,17 @@ config SENSORS_ULTRA45 This driver provides support for the U

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Steven Honeyman
On 28 March 2015 at 11:04, Paul Bolle wrote: > On Sat, 2015-03-28 at 11:24 +0100, Pali Rohár wrote: >> --- a/drivers/hwmon/Kconfig >> +++ b/drivers/hwmon/Kconfig >> @@ -1703,6 +1703,17 @@ config SENSORS_ULTRA45 >> This driver provides support for the Ultra45 workstation >> environmental >

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Paul Bolle
On Sat, 2015-03-28 at 11:24 +0100, Pali Rohár wrote: > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig > @@ -1703,6 +1703,17 @@ config SENSORS_ULTRA45 > This driver provides support for the Ultra45 workstation environmental > sensors. > > +config SENSORS_DELL_SMM > +

[PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Pali Rohár
This patch splits CONFIG_I8K compile option to SENSORS_DELL_SMM and CONFIG_I8K. Option SENSORS_DELL_SMM is now used to enable compilation of dell-smm-hwmon driver and old CONFIG_I8K option to enable /proc/i8k interface in driver. So this change allows to compile dell-smm-hwmon driver without legac