Re: [PATCH 2/2] f2fs: don't skip recovering inode depend on i_times

2016-11-05 Thread Jaegeuk Kim
On Sat, Nov 05, 2016 at 11:12:00AM +0800, Chao Yu wrote: > On 2016/11/5 6:53, Jaegeuk Kim wrote: > > On Fri, Nov 04, 2016 at 04:30:09PM +0800, Chao Yu wrote: > >> On 2016/11/4 2:02, Jaegeuk Kim wrote: > >>> On Fri, Nov 04, 2016 at 12:26:56AM +0800, Chao Yu wrote: > From: Chao Yu > >

Re: [PATCH 2/2] f2fs: don't skip recovering inode depend on i_times

2016-11-04 Thread Chao Yu
On 2016/11/5 6:53, Jaegeuk Kim wrote: > On Fri, Nov 04, 2016 at 04:30:09PM +0800, Chao Yu wrote: >> On 2016/11/4 2:02, Jaegeuk Kim wrote: >>> On Fri, Nov 04, 2016 at 12:26:56AM +0800, Chao Yu wrote: From: Chao Yu i_times of inode will be set with current system time which can be >>>

Re: [PATCH 2/2] f2fs: don't skip recovering inode depend on i_times

2016-11-04 Thread Jaegeuk Kim
On Fri, Nov 04, 2016 at 04:30:09PM +0800, Chao Yu wrote: > On 2016/11/4 2:02, Jaegeuk Kim wrote: > > On Fri, Nov 04, 2016 at 12:26:56AM +0800, Chao Yu wrote: > >> From: Chao Yu > >> > >> i_times of inode will be set with current system time which can be > >> configured through 'date', so it's not

Re: [PATCH 2/2] f2fs: don't skip recovering inode depend on i_times

2016-11-04 Thread Chao Yu
On 2016/11/4 2:02, Jaegeuk Kim wrote: > On Fri, Nov 04, 2016 at 12:26:56AM +0800, Chao Yu wrote: >> From: Chao Yu >> >> i_times of inode will be set with current system time which can be >> configured through 'date', so it's not safe to judge dnode block as >> garbage data depend on i_times. > >

Re: [PATCH 2/2] f2fs: don't skip recovering inode depend on i_times

2016-11-03 Thread Jaegeuk Kim
On Fri, Nov 04, 2016 at 12:26:56AM +0800, Chao Yu wrote: > From: Chao Yu > > i_times of inode will be set with current system time which can be > configured through 'date', so it's not safe to judge dnode block as > garbage data depend on i_times. This is not to detect garbage data, but to skip

[PATCH 2/2] f2fs: don't skip recovering inode depend on i_times

2016-11-03 Thread Chao Yu
From: Chao Yu i_times of inode will be set with current system time which can be configured through 'date', so it's not safe to judge dnode block as garbage data depend on i_times. Now, we have used enhanced 'cp_ver + cp' crc method to verify valid dnode block, so I expect recoverying invalid dn