Re: [PATCH 2/2] clk: core: link consumer with clock driver

2018-12-03 Thread Stephen Boyd
Quoting Miquel Raynal (2018-12-03 14:16:55) > Stephen Boyd wrote on Mon, 03 Dec 2018 11:20:31 > -0800: > > Quoting Miquel Raynal (2018-11-30 02:20:52) > > > Stephen Boyd wrote on Fri, 30 Nov 2018 01:26:20 > > > -0800: > > > > Quoting Miquel Raynal (2018-11-23 01:11:32) > > > > > > Because we n

Re: [PATCH 2/2] clk: core: link consumer with clock driver

2018-12-03 Thread Miquel Raynal
Hi Stephen, Stephen Boyd wrote on Mon, 03 Dec 2018 11:20:31 -0800: > Quoting Miquel Raynal (2018-11-30 02:20:52) > > Hi Stephen, > > > > Stephen Boyd wrote on Fri, 30 Nov 2018 01:26:20 > > -0800: > > > > > Quoting Miquel Raynal (2018-11-23 01:11:32) > > > > Would you agree with me adding

Re: [PATCH 2/2] clk: core: link consumer with clock driver

2018-12-03 Thread Stephen Boyd
Quoting Miquel Raynal (2018-11-30 02:20:52) > Hi Stephen, > > Stephen Boyd wrote on Fri, 30 Nov 2018 01:26:20 > -0800: > > > Quoting Miquel Raynal (2018-11-23 01:11:32) > > > Would you agree with me adding dummy functions in the #else section > > > like: > > > > > > static inline void __clk_dev

Re: [PATCH 2/2] clk: core: link consumer with clock driver

2018-11-30 Thread Miquel Raynal
Hi Stephen, Stephen Boyd wrote on Fri, 30 Nov 2018 01:26:20 -0800: > Quoting Miquel Raynal (2018-11-23 01:11:32) > > Would you agree with me adding dummy functions in the #else section > > like: > > > > static inline void __clk_device_link(struct device *consumer, struct clk > > *clk) > > { >

Re: [PATCH 2/2] clk: core: link consumer with clock driver

2018-11-30 Thread Stephen Boyd
Quoting Miquel Raynal (2018-11-23 01:11:32) > Would you agree with me adding dummy functions in the #else section > like: > > static inline void __clk_device_link(struct device *consumer, struct clk *clk) > { >return; > } > > static inline void __clk_device_unlink(struct clk *clk) > { >

Re: [PATCH 2/2] clk: core: link consumer with clock driver

2018-11-29 Thread Miquel Raynal
Hi Maxime, Maxime Ripard wrote on Tue, 27 Nov 2018 13:38:58 +0100: > Hi Miquel, > > On Thu, Nov 22, 2018 at 10:22:12PM +0100, Miquel Raynal wrote: > > One major concern when, for instance, suspending/resuming a platform > > is to never access registers before the underlying clock has been > > r

Re: [PATCH 2/2] clk: core: link consumer with clock driver

2018-11-27 Thread Maxime Ripard
Hi Miquel, On Thu, Nov 22, 2018 at 10:22:12PM +0100, Miquel Raynal wrote: > One major concern when, for instance, suspending/resuming a platform > is to never access registers before the underlying clock has been > resumed, otherwise most of the time the kernel will just crash. One > solution is t

Re: [PATCH 2/2] clk: core: link consumer with clock driver

2018-11-23 Thread Miquel Raynal
Hello, kbuild test robot wrote on Fri, 23 Nov 2018 16:30:00 +0800: > Hi Miquel, > > I love your patch! Yet something to improve: > > [auto build test ERROR on clk/clk-next] > [also build test ERROR on v4.20-rc3 next-20181122] > [if your patch is applied to the wrong git tree, please drop us a

Re: [PATCH 2/2] clk: core: link consumer with clock driver

2018-11-23 Thread kbuild test robot
Hi Miquel, I love your patch! Yet something to improve: [auto build test ERROR on clk/clk-next] [also build test ERROR on v4.20-rc3 next-20181122] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCH 2/2] clk: core: link consumer with clock driver

2018-11-22 Thread Miquel Raynal
One major concern when, for instance, suspending/resuming a platform is to never access registers before the underlying clock has been resumed, otherwise most of the time the kernel will just crash. One solution is to use syscore operations when registering clock drivers suspend/resume callbacks. O