Re: [PATCH 2/2] PCI: vmd: Enable ASPM for mobile platforms

2020-10-09 Thread Ian Kumlien
On Thu, Oct 8, 2020 at 6:19 AM Kai-Heng Feng wrote: > > > > > On Oct 7, 2020, at 21:30, Bjorn Helgaas wrote: > > > > On Wed, Oct 07, 2020 at 12:26:19PM +0800, Kai-Heng Feng wrote: > >>> On Oct 6, 2020, at 03:19, Bjorn Helgaas wrote: > >>> On Tue, Oct 06, 2020 at 02:40:32AM +0800, Kai-Heng Feng w

Re: [PATCH 2/2] PCI: vmd: Enable ASPM for mobile platforms

2020-10-07 Thread Kai-Heng Feng
> On Oct 7, 2020, at 21:30, Bjorn Helgaas wrote: > > On Wed, Oct 07, 2020 at 12:26:19PM +0800, Kai-Heng Feng wrote: >>> On Oct 6, 2020, at 03:19, Bjorn Helgaas wrote: >>> On Tue, Oct 06, 2020 at 02:40:32AM +0800, Kai-Heng Feng wrote: > On Oct 3, 2020, at 06:18, Bjorn Helgaas wrote: >

Re: [PATCH 2/2] PCI: vmd: Enable ASPM for mobile platforms

2020-10-07 Thread Ian Kumlien
On Wed, Oct 7, 2020 at 3:30 PM Bjorn Helgaas wrote: > > On Wed, Oct 07, 2020 at 12:26:19PM +0800, Kai-Heng Feng wrote: > > > On Oct 6, 2020, at 03:19, Bjorn Helgaas wrote: > > > On Tue, Oct 06, 2020 at 02:40:32AM +0800, Kai-Heng Feng wrote: > > >>> On Oct 3, 2020, at 06:18, Bjorn Helgaas wrote:

Re: [PATCH 2/2] PCI: vmd: Enable ASPM for mobile platforms

2020-10-07 Thread Bjorn Helgaas
On Wed, Oct 07, 2020 at 12:26:19PM +0800, Kai-Heng Feng wrote: > > On Oct 6, 2020, at 03:19, Bjorn Helgaas wrote: > > On Tue, Oct 06, 2020 at 02:40:32AM +0800, Kai-Heng Feng wrote: > >>> On Oct 3, 2020, at 06:18, Bjorn Helgaas wrote: > >>> On Wed, Sep 30, 2020 at 04:24:54PM +0800, Kai-Heng Feng w

Re: [PATCH 2/2] PCI: vmd: Enable ASPM for mobile platforms

2020-10-07 Thread Ian Kumlien
On Wed, Oct 7, 2020 at 6:26 AM Kai-Heng Feng wrote: > > > > > On Oct 6, 2020, at 03:19, Bjorn Helgaas wrote: > > > > [+cc Ian, who's also working on an ASPM issue] > > > > On Tue, Oct 06, 2020 at 02:40:32AM +0800, Kai-Heng Feng wrote: > >>> On Oct 3, 2020, at 06:18, Bjorn Helgaas wrote: > >>> On

Re: [PATCH 2/2] PCI: vmd: Enable ASPM for mobile platforms

2020-10-06 Thread Kai-Heng Feng
> On Oct 6, 2020, at 03:19, Bjorn Helgaas wrote: > > [+cc Ian, who's also working on an ASPM issue] > > On Tue, Oct 06, 2020 at 02:40:32AM +0800, Kai-Heng Feng wrote: >>> On Oct 3, 2020, at 06:18, Bjorn Helgaas wrote: >>> On Wed, Sep 30, 2020 at 04:24:54PM +0800, Kai-Heng Feng wrote: BI

Re: [PATCH 2/2] PCI: vmd: Enable ASPM for mobile platforms

2020-10-05 Thread Bjorn Helgaas
[+cc Ian, who's also working on an ASPM issue] On Tue, Oct 06, 2020 at 02:40:32AM +0800, Kai-Heng Feng wrote: > > On Oct 3, 2020, at 06:18, Bjorn Helgaas wrote: > > On Wed, Sep 30, 2020 at 04:24:54PM +0800, Kai-Heng Feng wrote: > >> BIOS may not be able to program ASPM for links behind VMD, preve

Re: [PATCH 2/2] PCI: vmd: Enable ASPM for mobile platforms

2020-10-05 Thread Kai-Heng Feng
Hi Bjorn, > On Oct 3, 2020, at 06:18, Bjorn Helgaas wrote: > > On Wed, Sep 30, 2020 at 04:24:54PM +0800, Kai-Heng Feng wrote: >> BIOS may not be able to program ASPM for links behind VMD, prevent Intel >> SoC from entering deeper power saving state. > > It's not a question of BIOS not being *ab

Re: [PATCH 2/2] PCI: vmd: Enable ASPM for mobile platforms

2020-10-02 Thread Bjorn Helgaas
On Wed, Sep 30, 2020 at 04:24:54PM +0800, Kai-Heng Feng wrote: > BIOS may not be able to program ASPM for links behind VMD, prevent Intel > SoC from entering deeper power saving state. It's not a question of BIOS not being *able* to configure ASPM. I think BIOS could do it, at least in principle,

[PATCH 2/2] PCI: vmd: Enable ASPM for mobile platforms

2020-09-30 Thread Kai-Heng Feng
BIOS may not be able to program ASPM for links behind VMD, prevent Intel SoC from entering deeper power saving state. So enable ASPM for links behind VMD to increase battery life. Signed-off-by: Kai-Heng Feng --- drivers/pci/controller/vmd.c | 22 +- 1 file changed, 21 inser