Re: [PATCH 2/2] PCI: Provide a default pcibios_update_irq()

2012-09-15 Thread Thierry Reding
On Sat, Sep 15, 2012 at 04:23:33PM -0600, Bjorn Helgaas wrote: > On Sat, Sep 15, 2012 at 1:53 AM, Thierry Reding > wrote: > > On Sat, Sep 15, 2012 at 09:32:10AM +0200, Geert Uytterhoeven wrote: > >> On Fri, Sep 14, 2012 at 10:44 PM, Thierry Reding > >> wrote: > >> > --- a/drivers/pci/setup-irq.c

Re: [PATCH 2/2] PCI: Provide a default pcibios_update_irq()

2012-09-15 Thread Bjorn Helgaas
On Sat, Sep 15, 2012 at 1:53 AM, Thierry Reding wrote: > On Sat, Sep 15, 2012 at 09:32:10AM +0200, Geert Uytterhoeven wrote: >> On Fri, Sep 14, 2012 at 10:44 PM, Thierry Reding >> wrote: >> > --- a/drivers/pci/setup-irq.c >> > +++ b/drivers/pci/setup-irq.c >> > @@ -17,6 +17,14 @@ >> > #include

Re: [PATCH 2/2] PCI: Provide a default pcibios_update_irq()

2012-09-15 Thread Bjorn Helgaas
On Sat, Sep 15, 2012 at 1:53 AM, Thierry Reding wrote: > On Sat, Sep 15, 2012 at 09:32:10AM +0200, Geert Uytterhoeven wrote: >> On Fri, Sep 14, 2012 at 10:44 PM, Thierry Reding >> wrote: >> > --- a/drivers/pci/setup-irq.c >> > +++ b/drivers/pci/setup-irq.c >> > @@ -17,6 +17,14 @@ >> > #include

Re: [PATCH 2/2] PCI: Provide a default pcibios_update_irq()

2012-09-15 Thread Thierry Reding
On Sat, Sep 15, 2012 at 09:32:10AM +0200, Geert Uytterhoeven wrote: > On Fri, Sep 14, 2012 at 10:44 PM, Thierry Reding > wrote: > > --- a/drivers/pci/setup-irq.c > > +++ b/drivers/pci/setup-irq.c > > @@ -17,6 +17,14 @@ > > #include > > #include > > > > +void __devinit __weak pcibios_update_irq

Re: [PATCH 2/2] PCI: Provide a default pcibios_update_irq()

2012-09-15 Thread Geert Uytterhoeven
On Fri, Sep 14, 2012 at 10:44 PM, Thierry Reding wrote: > --- a/drivers/pci/setup-irq.c > +++ b/drivers/pci/setup-irq.c > @@ -17,6 +17,14 @@ > #include > #include > > +void __devinit __weak pcibios_update_irq(struct pci_dev *dev, int irq) > +{ > +#ifdef CONFIG_PCI_DEBUG > + printk(KERN_D

[PATCH 2/2] PCI: Provide a default pcibios_update_irq()

2012-09-14 Thread Thierry Reding
Most architectures implement this in exactly the same way. Instead of having each architecture duplicate this function, provide a single implementation in the core and make it a weak symbol so that it can be overridden on architectures where it is required. Signed-off-by: Thierry Reding --- Note: