Re: [PATCH 2/2] MIPS: Watch: Avoid duplication of bits in mips_read_watch_registers

2018-01-22 Thread James Hogan
On Tue, Jan 02, 2018 at 11:31:22AM +, Matt Redfearn wrote: > Currently the bits to be masked when watchhi is read is defined inline > for each register. To avoid this, define the bits once and mask each > register with that value. > > Signed-off-by: Matt Redfearn Reviewed-by: James Hogan C

Re: [PATCH 2/2] MIPS: Watch: Avoid duplication of bits in mips_read_watch_registers

2018-01-05 Thread David Daney
On 01/02/2018 03:31 AM, Matt Redfearn wrote: Currently the bits to be masked when watchhi is read is defined inline for each register. To avoid this, define the bits once and mask each register with that value. Signed-off-by: Matt Redfearn Acked-by: David Daney --- arch/mips/kernel/wat

[PATCH 2/2] MIPS: Watch: Avoid duplication of bits in mips_read_watch_registers

2018-01-02 Thread Matt Redfearn
Currently the bits to be masked when watchhi is read is defined inline for each register. To avoid this, define the bits once and mask each register with that value. Signed-off-by: Matt Redfearn --- arch/mips/kernel/watch.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) d