Re: [PATCH 2/2] Input: da9055_onkey: convert to use devm_*

2014-08-08 Thread Dmitry Torokhov
Hi Kiran, On Fri, Aug 08, 2014 at 12:46:52PM +0530, Kiran Padwal wrote: > Converting to devm functions can make the code smaller and cleaner. Unfortunately it also makes it incorrect. As presented this conversion introduces race on driver removal. Before doing any more devm conversions please try

[PATCH 2/2] Input: da9055_onkey: convert to use devm_*

2014-08-08 Thread Kiran Padwal
Converting to devm functions can make the code smaller and cleaner. Signed-off-by: Kiran Padwal --- drivers/input/misc/da9055_onkey.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/drivers/input/misc/da9055_onkey.c b/drivers/input/misc/da9055_onkey