Re: [PATCH 2/2] Blackfin I2C/TWI driver: add missing pin mux operation

2007-11-01 Thread Bryan Wu
On 11/2/07, Mike Frysinger <[EMAIL PROTECTED]> wrote: > On 10/30/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > > --- a/drivers/i2c/busses/i2c-bfin-twi.c > > +++ b/drivers/i2c/busses/i2c-bfin-twi.c > > +static int setup_pin_mux(int action, struct bfin_twi_iface *iface) > > +{ > > + > > + u16 pin_r

Re: [PATCH 2/2] Blackfin I2C/TWI driver: add missing pin mux operation

2007-11-01 Thread Mike Frysinger
On 10/30/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > --- a/drivers/i2c/busses/i2c-bfin-twi.c > +++ b/drivers/i2c/busses/i2c-bfin-twi.c > +static int setup_pin_mux(int action, struct bfin_twi_iface *iface) > +{ > + > + u16 pin_req[2][3] = { > + {P_TWI0_SCL, P_TWI0_SDA, 0}, > +

Re: [PATCH 2/2] Blackfin I2C/TWI driver: add missing pin mux operation

2007-11-01 Thread Jean Delvare
On Tue, 30 Oct 2007 17:33:17 +0800, Bryan Wu wrote: Please include a description of the bug your patch is fixing. "missing pin mux operation" doesn't tell me much. > Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> > --- > drivers/i2c/busses/i2c-bfin-twi.c | 49

[PATCH 2/2] Blackfin I2C/TWI driver: add missing pin mux operation

2007-10-30 Thread Bryan Wu
Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> --- drivers/i2c/busses/i2c-bfin-twi.c | 49 1 files changed, 38 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c index acae7ef..832ba66 100644 --- a