Re: [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-11-19 Thread Cheng-yi Chiang
Hi Philipp, On Thu, Oct 18, 2018 at 1:02 AM Philipp Zabel wrote: > > Hi Maxime, > > On Fri, 2018-10-12 at 15:46 +0200, Maxime Ripard wrote: > > On Fri, Oct 12, 2018 at 12:05:16PM +0200, Philipp Zabel wrote: > [...] > > > What I would like better would be to let the consumers keep their reset- > >

Re: [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-10-17 Thread Philipp Zabel
Hi Maxime, On Fri, 2018-10-12 at 15:46 +0200, Maxime Ripard wrote: > On Fri, Oct 12, 2018 at 12:05:16PM +0200, Philipp Zabel wrote: [...] > > What I would like better would be to let the consumers keep their reset- > > gpios bindings, but add an optional hold time override in the DT: > > > >

Re: [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-10-12 Thread Maxime Ripard
On Fri, Oct 12, 2018 at 12:05:16PM +0200, Philipp Zabel wrote: > Hi Cheng-yi, > > [adding Maxime, devicetree to Cc:, the old discussion about GPIO resets > in [4] has never been resolved] > > On Tue, 2018-10-09 at 21:46 +0800, Cheng-yi Chiang wrote: > > +reset controller maintainer Philipp > > >

Re: [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-10-12 Thread Philipp Zabel
Hi Cheng-yi, [adding Maxime, devicetree to Cc:, the old discussion about GPIO resets in [4] has never been resolved] On Tue, 2018-10-09 at 21:46 +0800, Cheng-yi Chiang wrote: > +reset controller maintainer Philipp > > Hi Mark, > Sorry for the late reply. It took me a while to investigate reset

Re: [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-10-09 Thread Cheng-yi Chiang
+reset controller maintainer Philipp Hi Mark, Sorry for the late reply. It took me a while to investigate reset controller and its possible usage. I would like to figure out the proper way of reset handling because it is common to have a shared reset line for two max98927 codecs for left and rig

Re: [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-09-20 Thread Mark Brown
On Wed, Sep 12, 2018 at 08:19:55PM +0800, Cheng-Yi Chiang wrote: > + /* > + * Release reset GPIO because we are not going to use it. > + */ > + devm_gpiod_put(dev, max98927->reset_gpio); There is no need to do this, it's still potentially useful information for userspace and it'

Re: [alsa-devel] [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-09-20 Thread kbuild test robot
Hi Cheng-Yi, Thank you for the patch! Yet something to improve: [auto build test ERROR on asoc/for-next] [also build test ERROR on v4.19-rc4 next-20180919] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linu

Re: [alsa-devel] [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-09-17 Thread Mark Brown
On Mon, Sep 17, 2018 at 05:00:28PM +0800, Cheng-yi Chiang wrote: > Hi Mark, > Do you have any concern about this patch ? Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason

Re: [alsa-devel] [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-09-17 Thread Cheng-yi Chiang
Hi Mark, Do you have any concern about this patch ? Thanks! On Thu, Sep 13, 2018 at 12:47 AM Rohit Kumar wrote: > > > > On 9/12/2018 5:49 PM, Cheng-Yi Chiang wrote: > > Toggle reset line in max98927_i2c_probe. > > Use a list to store max98927 instances so we do not toggle reset line > > again if

Re: [alsa-devel] [PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-09-12 Thread Rohit Kumar
On 9/12/2018 5:49 PM, Cheng-Yi Chiang wrote: Toggle reset line in max98927_i2c_probe. Use a list to store max98927 instances so we do not toggle reset line again if more than one instances share the same reset line. Signed-off-by: Cheng-Yi Chiang Reviewed-and-tested-by: Rohit kumar ---

[PATCH 2/2] ASoC: max98927: Add reset-gpio support

2018-09-12 Thread Cheng-Yi Chiang
Toggle reset line in max98927_i2c_probe. Use a list to store max98927 instances so we do not toggle reset line again if more than one instances share the same reset line. Signed-off-by: Cheng-Yi Chiang --- sound/soc/codecs/max98927.c | 78 + sound/soc/