Re: [PATCH 2/14] drivers/power/ab8500_btemp.c: fix error return code

2012-08-22 Thread Anton Vorontsov
On Sun, Aug 19, 2012 at 10:44:22AM +0200, Julia Lawall wrote: > From: Julia Lawall [...] > Signed-off-by: Julia Lawall 2,3,4,5,6 applied, thanks! > --- > drivers/power/ab8500_btemp.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/power/ab8500_btemp.c b/drivers/power/ab850

[PATCH 2/14] drivers/power/ab8500_btemp.c: fix error return code

2012-08-19 Thread Julia Lawall
From: Julia Lawall Initialize return variable before exiting on an error path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when !=