Re: [PATCH 18/46] kernel: Mark functions as static in sched/fair.c

2014-02-28 Thread Peter Zijlstra
On Thu, Feb 27, 2014 at 03:09:05PM -0800, j...@joshtriplett.org wrote: > On Thu, Feb 27, 2014 at 08:24:35PM +0100, Peter Zijlstra wrote: > > On Thu, Feb 27, 2014 at 08:03:22AM -0800, Josh Triplett wrote: > > > Did you perhaps check, and notice that there are *zero* uses of this > > > function in th

Re: [PATCH 18/46] kernel: Mark functions as static in sched/fair.c

2014-02-27 Thread josh
On Thu, Feb 27, 2014 at 08:24:35PM +0100, Peter Zijlstra wrote: > On Thu, Feb 27, 2014 at 08:03:22AM -0800, Josh Triplett wrote: > > Did you perhaps check, and notice that there are *zero* uses of this > > function in the kernel? Nothing overrides this weak symbol; it is no > > longer needed. You

Re: [PATCH 18/46] kernel: Mark functions as static in sched/fair.c

2014-02-27 Thread Peter Zijlstra
On Thu, Feb 27, 2014 at 08:03:22AM -0800, Josh Triplett wrote: > On Thu, Feb 27, 2014 at 12:58:05PM +0100, Peter Zijlstra wrote: > > On Thu, Feb 27, 2014 at 05:20:19PM +0530, Rashika Kheria wrote: > > > @@ -5266,7 +5266,7 @@ static unsigned long default_scale_smt_power(struct > > > sched_domain *s

Re: [PATCH 18/46] kernel: Mark functions as static in sched/fair.c

2014-02-27 Thread Josh Triplett
On Thu, Feb 27, 2014 at 12:58:05PM +0100, Peter Zijlstra wrote: > On Thu, Feb 27, 2014 at 05:20:19PM +0530, Rashika Kheria wrote: > > @@ -5266,7 +5266,7 @@ static unsigned long default_scale_smt_power(struct > > sched_domain *sd, int cpu) > > return smt_gain; > > } > > > > -unsigned long __

Re: [PATCH 18/46] kernel: Mark functions as static in sched/fair.c

2014-02-27 Thread Peter Zijlstra
On Thu, Feb 27, 2014 at 05:20:19PM +0530, Rashika Kheria wrote: > @@ -5266,7 +5266,7 @@ static unsigned long default_scale_smt_power(struct > sched_domain *sd, int cpu) > return smt_gain; > } > > -unsigned long __weak arch_scale_smt_power(struct sched_domain *sd, int cpu) > +static unsign

[PATCH 18/46] kernel: Mark functions as static in sched/fair.c

2014-02-27 Thread Rashika Kheria
Mark functions as static in kernel/sched/fair.c because they are not used outside this file. This eliminates the following warning in kernel/sched/fair.c: kernel/sched/fair.c:1658:6: warning: no previous prototype for ‘task_numa_work’ [-Wmissing-prototypes] kernel/sched/fair.c:1780:6: warning: no