Re: [PATCH 17/39] mtd: nand: denali: support HW_ECC_FIXUP capability

2016-11-29 Thread Boris Brezillon
On Wed, 30 Nov 2016 15:20:10 +0900 Masahiro Yamada wrote: > Hi Boris, > > > 2016-11-28 1:09 GMT+09:00 Boris Brezillon > : > &max_bitflips); > > > > Okay, so you currently have two ways of handling ECC errors. What if a > > new revision introduces yet ano

Re: [PATCH 17/39] mtd: nand: denali: support HW_ECC_FIXUP capability

2016-11-29 Thread Masahiro Yamada
Hi Boris, 2016-11-28 1:09 GMT+09:00 Boris Brezillon : &max_bitflips); > > Okay, so you currently have two ways of handling ECC errors. What if a > new revision introduces yet another way to do it? > > How about making denali_caps a structure where you have

Re: [PATCH 17/39] mtd: nand: denali: support HW_ECC_FIXUP capability

2016-11-27 Thread Boris Brezillon
On Sun, 27 Nov 2016 03:06:03 +0900 Masahiro Yamada wrote: > Some old versions of the Denali IP (perhaps used only for Intel?) > detects ECC errors and provides correct data via a register, but > does not touch the transferred data. So, the software must fixup > the data in the buffer according t

[PATCH 17/39] mtd: nand: denali: support HW_ECC_FIXUP capability

2016-11-26 Thread Masahiro Yamada
Some old versions of the Denali IP (perhaps used only for Intel?) detects ECC errors and provides correct data via a register, but does not touch the transferred data. So, the software must fixup the data in the buffer according to the provided ECC correction information. Newer versions perform E