Re: [PATCH 16/35] perf annotate: Add samples into struct annotation_line

2017-11-15 Thread Ravi Bangoria
Hi Jiri, On 11/15/2017 07:34 PM, Jiri Olsa wrote: On Tue, Nov 14, 2017 at 11:29:54AM +0100, Jiri Olsa wrote: On Tue, Nov 14, 2017 at 03:45:27PM +0530, Ravi Bangoria wrote: Hi Jiri, On 11/14/2017 03:01 PM, Jiri Olsa wrote: On Mon, Nov 13, 2017 at 09:14:38PM +0100, Jiri Olsa wrote: On Mon, N

Re: [PATCH 16/35] perf annotate: Add samples into struct annotation_line

2017-11-15 Thread Jiri Olsa
On Tue, Nov 14, 2017 at 11:29:54AM +0100, Jiri Olsa wrote: > On Tue, Nov 14, 2017 at 03:45:27PM +0530, Ravi Bangoria wrote: > > Hi Jiri, > > > > On 11/14/2017 03:01 PM, Jiri Olsa wrote: > > > On Mon, Nov 13, 2017 at 09:14:38PM +0100, Jiri Olsa wrote: > > > > On Mon, Nov 13, 2017 at 09:16:20PM +053

Re: [PATCH 16/35] perf annotate: Add samples into struct annotation_line

2017-11-14 Thread Jiri Olsa
On Tue, Nov 14, 2017 at 03:45:27PM +0530, Ravi Bangoria wrote: > Hi Jiri, > > On 11/14/2017 03:01 PM, Jiri Olsa wrote: > > On Mon, Nov 13, 2017 at 09:14:38PM +0100, Jiri Olsa wrote: > > > On Mon, Nov 13, 2017 at 09:16:20PM +0530, Ravi Bangoria wrote: > > > > Hi Jiri, > > > > > > > > This patch se

Re: [PATCH 16/35] perf annotate: Add samples into struct annotation_line

2017-11-14 Thread Ravi Bangoria
Hi Jiri, On 11/14/2017 03:01 PM, Jiri Olsa wrote: On Mon, Nov 13, 2017 at 09:14:38PM +0100, Jiri Olsa wrote: On Mon, Nov 13, 2017 at 09:16:20PM +0530, Ravi Bangoria wrote: Hi Jiri, This patch seems to be causing segfault with "perf top --stdio". Steps to reproduce: 1. start "perf top --stdio

Re: [PATCH 16/35] perf annotate: Add samples into struct annotation_line

2017-11-14 Thread Jiri Olsa
On Mon, Nov 13, 2017 at 09:14:38PM +0100, Jiri Olsa wrote: > On Mon, Nov 13, 2017 at 09:16:20PM +0530, Ravi Bangoria wrote: > > Hi Jiri, > > > > This patch seems to be causing segfault with "perf top --stdio". > > > > Steps to reproduce: > > 1. start "perf top --stdio" in one terminal > > 2. run

Re: [PATCH 16/35] perf annotate: Add samples into struct annotation_line

2017-11-13 Thread Jiri Olsa
On Mon, Nov 13, 2017 at 09:16:20PM +0530, Ravi Bangoria wrote: > Hi Jiri, > > This patch seems to be causing segfault with "perf top --stdio". > > Steps to reproduce: > 1. start "perf top --stdio" in one terminal > 2. run some simple workload in another terminal, let it get finished. > 3. annotat

Re: [PATCH 16/35] perf annotate: Add samples into struct annotation_line

2017-11-13 Thread Ravi Bangoria
Hi Jiri, This patch seems to be causing segfault with "perf top --stdio". Steps to reproduce: 1. start "perf top --stdio" in one terminal 2. run some simple workload in another terminal, let it get finished. 3. annotate function from previous workload in perf top (press 'a' followed by 's') P

[PATCH 16/35] perf annotate: Add samples into struct annotation_line

2017-10-11 Thread Jiri Olsa
Adding samples array into struct annotation_line to hold the annotation data. The data are populated in the following patches. Link: http://lkml.kernel.org/n/tip-97yja5m7z9brrcuf2gwr5...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/annotate.c | 8 tools/perf/util/annotat