Re: [PATCH 16/26] dmaengine: Convert to new IDA API

2018-06-26 Thread Matthew Wilcox
On Sun, Jun 24, 2018 at 09:57:45AM +0200, Lars-Peter Clausen wrote: > > + int rc = ida_alloc(&dma_ida, GFP_KERNEL); > > > > + if (rc >= 0) > > + device->dev_id = rc; > > return rc; > > This used to return 0 on success, now it returns the ID. That wont work > considering that it

Re: [PATCH 16/26] dmaengine: Convert to new IDA API

2018-06-24 Thread Lars-Peter Clausen
On 06/21/2018 11:28 PM, Matthew Wilcox wrote: > Simpler and shorter code. > > Signed-off-by: Matthew Wilcox > --- [...]> { > - int rc; > - > - do { > - if (!ida_pre_get(&dma_ida, GFP_KERNEL)) > - return -ENOMEM; > - mutex_lock(&dma_list_mutex);

Re: [PATCH 16/26] dmaengine: Convert to new IDA API

2018-06-23 Thread Matthew Wilcox
On Sat, Jun 23, 2018 at 06:00:39PM +0530, Vinod wrote: > On 21-06-18, 14:28, Matthew Wilcox wrote: > > Simpler and shorter code. > > I couldn't find ida_alloc/ida_free in 4.18-rc1 so I assume this will go > thru tree adding this so: > > Acked-by: Vinod Koul Yup, you were bcc'd on patch 3/26 whi

Re: [PATCH 16/26] dmaengine: Convert to new IDA API

2018-06-23 Thread Vinod
On 21-06-18, 14:28, Matthew Wilcox wrote: > Simpler and shorter code. I couldn't find ida_alloc/ida_free in 4.18-rc1 so I assume this will go thru tree adding this so: Acked-by: Vinod Koul > > Signed-off-by: Matthew Wilcox > --- > drivers/dma/dmaengine.c | 20 +--- > 1 file c

[PATCH 16/26] dmaengine: Convert to new IDA API

2018-06-21 Thread Matthew Wilcox
Simpler and shorter code. Signed-off-by: Matthew Wilcox --- drivers/dma/dmaengine.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c index 08ba8473a284..1e9bdadfc312 100644 --- a/drivers/dma/dmaengine.c ++