Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

2007-03-08 Thread Pavel Machek
Hi! > > > Signed-off-by: Vivek Goyal <[EMAIL PROTECTED]> > > > > > +static int swsusp_header_init(void) > > > +{ > > > + swsusp_header = (struct swsusp_header*) __get_free_page(GFP_KERNEL); > > > + if (!swsusp_header) > > > + panic("Could not allocate memory for swsusp_header\n"); > > > +

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

2007-03-08 Thread Pavel Machek
Hi! > > > o virt_to_page() call should be used on kernel linear addresses and not > > > on kernel text and data addresses. Swsusp code uses it on kernel data > > > (statically allocated swsusp_header). > > > > > > o Allocate swsusp_header dynamically so that virt_to_page() can be used > > >

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

2007-03-07 Thread Vivek Goyal
On Wed, Mar 07, 2007 at 11:49:15PM +0100, Pavel Machek wrote: > Hi! > > > o virt_to_page() call should be used on kernel linear addresses and not > > on kernel text and data addresses. Swsusp code uses it on kernel data > > (statically allocated swsusp_header). > > > > o Allocate swsusp_heade

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

2007-03-07 Thread Vivek Goyal
On Wed, Mar 07, 2007 at 11:50:06PM +0100, Pavel Machek wrote: > Hi! > > > o virt_to_page() call should be used on kernel linear addresses and not > > on kernel text and data addresses. Swsusp code uses it on kernel data > > (statically allocated swsusp_header). > > > > o Allocate swsusp_heade

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

2007-03-07 Thread Nigel Cunningham
Hi. On Wed, 2007-03-07 at 23:50 +0100, Pavel Machek wrote: > Hi! > > > o virt_to_page() call should be used on kernel linear addresses and not > > on kernel text and data addresses. Swsusp code uses it on kernel data > > (statically allocated swsusp_header). > > > > o Allocate swsusp_header

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

2007-03-07 Thread Pavel Machek
Hi! > o virt_to_page() call should be used on kernel linear addresses and not > on kernel text and data addresses. Swsusp code uses it on kernel data > (statically allocated swsusp_header). > > o Allocate swsusp_header dynamically so that virt_to_page() can be used > safely. > > o I am cha

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

2007-03-07 Thread Pavel Machek
Hi! > o virt_to_page() call should be used on kernel linear addresses and not > on kernel text and data addresses. Swsusp code uses it on kernel data > (statically allocated swsusp_header). > > o Allocate swsusp_header dynamically so that virt_to_page() can be used > safely. > > o I am cha

[PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

2007-03-06 Thread Vivek Goyal
o virt_to_page() call should be used on kernel linear addresses and not on kernel text and data addresses. Swsusp code uses it on kernel data (statically allocated swsusp_header). o Allocate swsusp_header dynamically so that virt_to_page() can be used safely. o I am changing this because