Re: [PATCH 15/25] mm, compaction: Finish pageblock scanning on contention

2019-01-18 Thread Vlastimil Babka
On 1/17/19 6:11 PM, Mel Gorman wrote: > On Thu, Jan 17, 2019 at 05:38:36PM +0100, Vlastimil Babka wrote: >> > rate but also by the fact that the scanners do not meet for longer when >> > pageblocks are actually used. Overall this is justified and completing >> > a pageblock scan is very important f

Re: [PATCH 15/25] mm, compaction: Finish pageblock scanning on contention

2019-01-17 Thread Mel Gorman
On Thu, Jan 17, 2019 at 05:38:36PM +0100, Vlastimil Babka wrote: > > rate but also by the fact that the scanners do not meet for longer when > > pageblocks are actually used. Overall this is justified and completing > > a pageblock scan is very important for later patches. > > > > Signed-off-by: M

Re: [PATCH 15/25] mm, compaction: Finish pageblock scanning on contention

2019-01-17 Thread Vlastimil Babka
On 1/4/19 1:50 PM, Mel Gorman wrote: > Async migration aborts on spinlock contention but contention can be high > when there are multiple compaction attempts and kswapd is active. The > consequence is that the migration scanners move forward uselessly while > still contending on locks for longer wh

[PATCH 15/25] mm, compaction: Finish pageblock scanning on contention

2019-01-04 Thread Mel Gorman
Async migration aborts on spinlock contention but contention can be high when there are multiple compaction attempts and kswapd is active. The consequence is that the migration scanners move forward uselessly while still contending on locks for longer while leaving suitable migration sources behind