Re: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-28 Thread J. Bruce Fields
On Sat, Jan 26, 2013 at 01:34:56PM +, Arnd Bergmann wrote: > On Saturday 26 January 2013, Russell King - ARM Linux wrote: > > On Fri, Jan 25, 2013 at 11:45:25PM +, Arnd Bergmann wrote: > > > On Friday 25 January 2013, Myklebust, Trond wrote: > > > > > -Original Message- > > > > > Fr

Re: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-26 Thread Arnd Bergmann
On Saturday 26 January 2013, Russell King - ARM Linux wrote: > On Fri, Jan 25, 2013 at 11:45:25PM +, Arnd Bergmann wrote: > > On Friday 25 January 2013, Myklebust, Trond wrote: > > > > -Original Message- > > > > From: Arnd Bergmann [mailto:a...@arndb.de] > > > > Marking it as __maybe_un

Re: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-26 Thread Russell King - ARM Linux
On Fri, Jan 25, 2013 at 11:45:25PM +, Arnd Bergmann wrote: > On Friday 25 January 2013, Myklebust, Trond wrote: > > > -Original Message- > > > From: Arnd Bergmann [mailto:a...@arndb.de] > > > Marking it as __maybe_unused avoids a harmless gcc warning. > > > > Alternatively, just declar

Re: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-25 Thread Arnd Bergmann
On Friday 25 January 2013, Myklebust, Trond wrote: > > -Original Message- > > From: Arnd Bergmann [mailto:a...@arndb.de] > > Marking it as __maybe_unused avoids a harmless gcc warning. > > Alternatively, just declare it using the RPC_IFDEBUG() macro. Right, makes sense: that's more consis

RE: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-25 Thread Myklebust, Trond
..@vger.kernel.org > Subject: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf' > > When RPC_DEBUG is unset, the dprintk() macro does nothing, causing the > 'buf' variable in svc_printk to become unused. > Marking it as __maybe_unused avoids

[PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-25 Thread Arnd Bergmann
When RPC_DEBUG is unset, the dprintk() macro does nothing, causing the 'buf' variable in svc_printk to become unused. Marking it as __maybe_unused avoids a harmless gcc warning. Without this patch, building at91_dt_defconfig results in: net/sunrpc/svc.c: In function 'svc_printk': net/sunrpc/svc.c

[PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-25 Thread Arnd Bergmann
When RPC_DEBUG is unset, the dprintk() macro does nothing, causing the 'buf' variable in svc_printk to become unused. Marking it as __maybe_unused avoids a harmless gcc warning. Without this patch, building at91_dt_defconfig results in: net/sunrpc/svc.c: In function 'svc_printk': net/sunrpc/svc.c