Re: [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h

2013-06-05 Thread Grant Likely
On Tue, 4 Jun 2013 17:24:51 -0500, Rob Herring wrote: > On Tue, Jun 4, 2013 at 12:51 PM, Arnd Bergmann wrote: > > On Tuesday 04 June 2013, Rob Herring wrote: > >> On Sat, Jun 1, 2013 at 3:57 PM, Arnd Bergmann wrote: > >> > On Saturday 01 June 2013, Rob Herring wrote: > >> >> No, we still need em

Re: [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h

2013-06-05 Thread Arnd Bergmann
On Tuesday 04 June 2013 17:24:51 Rob Herring wrote: > > Right. I get all that. You still have to go add inlines if you want to make: > > if (IS_ENABLED(CONFIG_OF)) > of_foo(); > > just be: > > of_foo(); > > There are situations for both and only inlines cover both cases. I > don't see a re

Re: [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h

2013-06-04 Thread Rob Herring
On Tue, Jun 4, 2013 at 12:51 PM, Arnd Bergmann wrote: > On Tuesday 04 June 2013, Rob Herring wrote: >> On Sat, Jun 1, 2013 at 3:57 PM, Arnd Bergmann wrote: >> > On Saturday 01 June 2013, Rob Herring wrote: >> >> No, we still need empty functions. Here is what of_device.h looks like: >> >> >> >> h

Re: [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h

2013-06-04 Thread Arnd Bergmann
On Tuesday 04 June 2013, Rob Herring wrote: > On Sat, Jun 1, 2013 at 3:57 PM, Arnd Bergmann wrote: > > On Saturday 01 June 2013, Rob Herring wrote: > >> No, we still need empty functions. Here is what of_device.h looks like: > >> > >> http://tinyurl.com/l2azz5m > >> > >> BTW, it has your ack. > >>

Re: [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h

2013-06-04 Thread Rob Herring
On Sat, Jun 1, 2013 at 3:57 PM, Arnd Bergmann wrote: > On Saturday 01 June 2013, Rob Herring wrote: >> No, we still need empty functions. Here is what of_device.h looks like: >> >> http://tinyurl.com/l2azz5m >> >> BTW, it has your ack. >> > > Could you add a patch on top that only puts the functio

Re: [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h

2013-06-01 Thread Arnd Bergmann
On Saturday 01 June 2013, Rob Herring wrote: > No, we still need empty functions. Here is what of_device.h looks like: > > http://tinyurl.com/l2azz5m > > BTW, it has your ack. > Could you add a patch on top that only puts the function declarations inside of #ifdef that don't have an inline wrap

Re: [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h

2013-06-01 Thread Rob Herring
On 06/01/2013 03:03 PM, Arnd Bergmann wrote: > On Saturday 01 June 2013, Rob Herring wrote: >> On Fri, May 31, 2013 at 5:22 PM, Arnd Bergmann wrote: >>> A lot of code uses the functions from of_platform.h when built for >>> devicetree-enabled platforms but can also be built without them. >>> In or

Re: [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h

2013-06-01 Thread Arnd Bergmann
On Saturday 01 June 2013, Rob Herring wrote: > On Fri, May 31, 2013 at 5:22 PM, Arnd Bergmann wrote: > > A lot of code uses the functions from of_platform.h when built for > > devicetree-enabled platforms but can also be built without them. > > In order to avoid using #ifdef everywhere in drivers,

Re: [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h

2013-06-01 Thread Rob Herring
On Fri, May 31, 2013 at 5:22 PM, Arnd Bergmann wrote: > A lot of code uses the functions from of_platform.h when built for > devicetree-enabled platforms but can also be built without them. > In order to avoid using #ifdef everywhere in drivers, this > makes all the function declarations visible,

[PATCH 15/15] OF: remove #ifdef from linux/of_platform.h

2013-05-31 Thread Arnd Bergmann
A lot of code uses the functions from of_platform.h when built for devicetree-enabled platforms but can also be built without them. In order to avoid using #ifdef everywhere in drivers, this makes all the function declarations visible, which means we can use "if (IS_ENABLED(CONFIG_OF))" in driver c