Re: [PATCH 14/25] ubifs: Add authentication nodes to journal

2018-09-02 Thread Richard Weinberger
Am Mittwoch, 29. August 2018, 16:38:34 CEST schrieb Sascha Hauer: > I assumed that make_reservation would align len anyway. I can't find the > place that led me to that assumption anymore and even if this is true > it's probably safer to just stick to the original len for the > non-authenticated ca

Re: [PATCH 14/25] ubifs: Add authentication nodes to journal

2018-08-30 Thread Sascha Hauer
On Wed, Aug 29, 2018 at 04:54:30PM +0200, Richard Weinberger wrote: > Am Mittwoch, 29. August 2018, 16:38:34 CEST schrieb Sascha Hauer: > > On Mon, Aug 27, 2018 at 10:48:26PM +0200, Richard Weinberger wrote: > > > > release_head(c, BASEHD); > > > > kfree(dent); > > > > + ubifs

Re: [PATCH 14/25] ubifs: Add authentication nodes to journal

2018-08-29 Thread Richard Weinberger
Am Mittwoch, 29. August 2018, 16:38:34 CEST schrieb Sascha Hauer: > On Mon, Aug 27, 2018 at 10:48:26PM +0200, Richard Weinberger wrote: > > > release_head(c, BASEHD); > > > kfree(dent); > > > + ubifs_add_dirt(c, lnum, ubifs_auth_node_sz(c)); > > > > You have to account it immediately because w

Re: [PATCH 14/25] ubifs: Add authentication nodes to journal

2018-08-29 Thread Sascha Hauer
On Mon, Aug 27, 2018 at 10:48:26PM +0200, Richard Weinberger wrote: > Am Mittwoch, 4. Juli 2018, 14:41:26 CEST schrieb Sascha Hauer: > > Nodes that are written to flash can only be authenticated through the > > index after the next commit. When a journal replay is necessary the > > nodes are not ye

Re: [PATCH 14/25] ubifs: Add authentication nodes to journal

2018-08-27 Thread Richard Weinberger
Am Mittwoch, 4. Juli 2018, 14:41:26 CEST schrieb Sascha Hauer: > Nodes that are written to flash can only be authenticated through the > index after the next commit. When a journal replay is necessary the > nodes are not yet referenced by the index and thus can't be > authenticated. > > This patch

Re: [PATCH 14/25] ubifs: Add authentication nodes to journal

2018-07-07 Thread kbuild test robot
Hi Sascha, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.18-rc3 next-20180706] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCH 14/25] ubifs: Add authentication nodes to journal

2018-07-04 Thread Sascha Hauer
Nodes that are written to flash can only be authenticated through the index after the next commit. When a journal replay is necessary the nodes are not yet referenced by the index and thus can't be authenticated. This patch overcomes this situation by creating a hash over all nodes beginning from