[PATCH 14/17] memremap: simplify duplicate region handling in devm_memremap_pages

2017-12-28 Thread Christoph Hellwig
__radix_tree_insert already checks for duplicates and returns -EEXIST in that case, so remove the duplicate (and racy) duplicates check. Signed-off-by: Christoph Hellwig Reviewed-by: Logan Gunthorpe --- kernel/memremap.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/kernel/mem

Re: [PATCH 14/17] memremap: simplify duplicate region handling in devm_memremap_pages

2017-12-19 Thread Christoph Hellwig
On Sun, Dec 17, 2017 at 09:34:11AM -0800, Dan Williams wrote: > This is not racy, we'll catch the error on insert, and I think the > extra debug information is useful for debugging a broken memory map or > alignment math. We can check for -ЕEXIST and print the warning, but it's a weird pattern for

Re: [PATCH 14/17] memremap: simplify duplicate region handling in devm_memremap_pages

2017-12-17 Thread Dan Williams
On Fri, Dec 15, 2017 at 6:09 AM, Christoph Hellwig wrote: > __radix_tree_insert already checks for duplicates and returns -EEXIST in > that case, so remove the duplicate (and racy) duplicates check. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Logan Gunthorpe > --- > kernel/memremap.c |

[PATCH 14/17] memremap: simplify duplicate region handling in devm_memremap_pages

2017-12-15 Thread Christoph Hellwig
__radix_tree_insert already checks for duplicates and returns -EEXIST in that case, so remove the duplicate (and racy) duplicates check. Signed-off-by: Christoph Hellwig Reviewed-by: Logan Gunthorpe --- kernel/memremap.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/kernel/mem