Re: [PATCH 13/26] locking: Add non-fatal spin lock assert

2014-09-10 Thread Greg Kroah-Hartman
On Wed, Sep 10, 2014 at 10:45:33AM -0400, Peter Hurley wrote: > On 09/10/2014 09:08 AM, Peter Zijlstra wrote: > > On Wed, Sep 10, 2014 at 07:02:10AM -0400, Peter Hurley wrote: > >> On 09/04/2014 01:14 AM, Ingo Molnar wrote: > >>> > >>> * Peter Zijlstra wrote: > >>> > On Wed, Sep 03, 2014 at 1

Re: [PATCH 13/26] locking: Add non-fatal spin lock assert

2014-09-10 Thread Peter Hurley
On 09/10/2014 09:08 AM, Peter Zijlstra wrote: > On Wed, Sep 10, 2014 at 07:02:10AM -0400, Peter Hurley wrote: >> On 09/04/2014 01:14 AM, Ingo Molnar wrote: >>> >>> * Peter Zijlstra wrote: >>> On Wed, Sep 03, 2014 at 10:50:01AM -0400, Peter Hurley wrote: > So a lockdep-only assert is unlik

Re: [PATCH 13/26] locking: Add non-fatal spin lock assert

2014-09-10 Thread Peter Zijlstra
On Wed, Sep 10, 2014 at 07:02:10AM -0400, Peter Hurley wrote: > On 09/04/2014 01:14 AM, Ingo Molnar wrote: > > > > * Peter Zijlstra wrote: > > > >> On Wed, Sep 03, 2014 at 10:50:01AM -0400, Peter Hurley wrote: > >>> So a lockdep-only assert is unlikely to draw attention to existing bugs, > >>> e

Re: [PATCH 13/26] locking: Add non-fatal spin lock assert

2014-09-10 Thread Peter Hurley
On 09/04/2014 01:14 AM, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > >> On Wed, Sep 03, 2014 at 10:50:01AM -0400, Peter Hurley wrote: >>> So a lockdep-only assert is unlikely to draw attention to existing bugs, >>> especially in established drivers. >> >> By the same logic lockdep will not f

Re: [PATCH 13/26] locking: Add non-fatal spin lock assert

2014-09-03 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Wed, Sep 03, 2014 at 10:50:01AM -0400, Peter Hurley wrote: > > So a lockdep-only assert is unlikely to draw attention to existing bugs, > > especially in established drivers. > > By the same logic lockdep will not find locking errors in established > drivers. Indee

Re: [PATCH 13/26] locking: Add non-fatal spin lock assert

2014-09-03 Thread Peter Zijlstra
On Wed, Sep 03, 2014 at 10:50:01AM -0400, Peter Hurley wrote: > So a lockdep-only assert is unlikely to draw attention to existing bugs, > especially in established drivers. By the same logic lockdep will not find locking errors in established drivers. -- To unsubscribe from this list: send the li

Re: [PATCH 13/26] locking: Add non-fatal spin lock assert

2014-09-03 Thread Peter Hurley
On 09/03/2014 10:40 AM, Peter Zijlstra wrote: > On Wed, Sep 03, 2014 at 07:20:04AM -0400, Peter Hurley wrote: >> Hi Peter, >> >> On 09/03/2014 05:27 AM, Peter Zijlstra wrote: >>> On Tue, Sep 02, 2014 at 05:39:22PM -0400, Peter Hurley wrote: Provide method for non-essential or non-critical code

Re: [PATCH 13/26] locking: Add non-fatal spin lock assert

2014-09-03 Thread Peter Zijlstra
On Wed, Sep 03, 2014 at 07:20:04AM -0400, Peter Hurley wrote: > Hi Peter, > > On 09/03/2014 05:27 AM, Peter Zijlstra wrote: > > On Tue, Sep 02, 2014 at 05:39:22PM -0400, Peter Hurley wrote: > >> Provide method for non-essential or non-critical code to warn of > >> invariant errors. > >> > >> CC: I

Re: [PATCH 13/26] locking: Add non-fatal spin lock assert

2014-09-03 Thread Peter Hurley
Hi Peter, On 09/03/2014 05:27 AM, Peter Zijlstra wrote: > On Tue, Sep 02, 2014 at 05:39:22PM -0400, Peter Hurley wrote: >> Provide method for non-essential or non-critical code to warn of >> invariant errors. >> >> CC: Ingo Molnar >> CC: Peter Zijlstra >> CC: Thomas Gleixner >> Signed-off-by: P

Re: [PATCH 13/26] locking: Add non-fatal spin lock assert

2014-09-03 Thread Peter Zijlstra
On Tue, Sep 02, 2014 at 05:39:22PM -0400, Peter Hurley wrote: > Provide method for non-essential or non-critical code to warn of > invariant errors. > > CC: Ingo Molnar > CC: Peter Zijlstra > CC: Thomas Gleixner > Signed-off-by: Peter Hurley > --- > include/linux/spinlock.h | 1 + > i

[PATCH 13/26] locking: Add non-fatal spin lock assert

2014-09-02 Thread Peter Hurley
Provide method for non-essential or non-critical code to warn of invariant errors. CC: Ingo Molnar CC: Peter Zijlstra CC: Thomas Gleixner Signed-off-by: Peter Hurley --- include/linux/spinlock.h | 1 + include/linux/spinlock_api_smp.h | 1 + include/linux/spinlock_api_up.h | 1 + 3 f