Re: [PATCH 13/18] perf metric: Add events for the current group

2020-07-16 Thread Jiri Olsa
On Wed, Jul 15, 2020 at 03:14:37PM -0700, Ian Rogers wrote: > On Wed, Jul 15, 2020 at 2:19 PM Jiri Olsa wrote: > > > > On Wed, Jul 15, 2020 at 10:00:09AM -0700, Ian Rogers wrote: > > > On Sun, Jul 12, 2020 at 6:27 AM Jiri Olsa wrote: > > > > > > > > There's no need to iterate the whole list of gr

Re: [PATCH 13/18] perf metric: Add events for the current group

2020-07-15 Thread Ian Rogers
On Wed, Jul 15, 2020 at 2:19 PM Jiri Olsa wrote: > > On Wed, Jul 15, 2020 at 10:00:09AM -0700, Ian Rogers wrote: > > On Sun, Jul 12, 2020 at 6:27 AM Jiri Olsa wrote: > > > > > > There's no need to iterate the whole list of groups, > > > when adding new events. The currently created group > > > is

Re: [PATCH 13/18] perf metric: Add events for the current group

2020-07-15 Thread Jiri Olsa
On Wed, Jul 15, 2020 at 10:00:09AM -0700, Ian Rogers wrote: > On Sun, Jul 12, 2020 at 6:27 AM Jiri Olsa wrote: > > > > There's no need to iterate the whole list of groups, > > when adding new events. The currently created group > > is the one we want to add. > > > > Signed-off-by: Jiri Olsa > > -

Re: [PATCH 13/18] perf metric: Add events for the current group

2020-07-15 Thread Ian Rogers
On Sun, Jul 12, 2020 at 6:27 AM Jiri Olsa wrote: > > There's no need to iterate the whole list of groups, > when adding new events. The currently created group > is the one we want to add. > > Signed-off-by: Jiri Olsa > --- > tools/perf/util/metricgroup.c | 22 -- > 1 file ch

[PATCH 13/18] perf metric: Add events for the current group

2020-07-12 Thread Jiri Olsa
There's no need to iterate the whole list of groups, when adding new events. The currently created group is the one we want to add. Signed-off-by: Jiri Olsa --- tools/perf/util/metricgroup.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/tools/perf/u