Re: [PATCH 13/17] coresight etr: Do not clean ETR trace buffer

2017-11-07 Thread Suzuki K Poulose
On 03/11/17 20:17, Mathieu Poirier wrote: On 3 November 2017 at 04:10, Suzuki K Poulose wrote: On 02/11/17 20:36, Mathieu Poirier wrote: On Thu, Oct 19, 2017 at 06:15:49PM +0100, Suzuki K Poulose wrote: We zero out the entire trace buffer used for ETR before it is enabled, for helping with

Re: [PATCH 13/17] coresight etr: Do not clean ETR trace buffer

2017-11-03 Thread Mathieu Poirier
On 3 November 2017 at 04:10, Suzuki K Poulose wrote: > On 02/11/17 20:36, Mathieu Poirier wrote: >> >> On Thu, Oct 19, 2017 at 06:15:49PM +0100, Suzuki K Poulose wrote: >>> >>> We zero out the entire trace buffer used for ETR before it >>> is enabled, for helping with debugging. Since we could be

Re: [PATCH 13/17] coresight etr: Do not clean ETR trace buffer

2017-11-03 Thread Suzuki K Poulose
On 02/11/17 20:36, Mathieu Poirier wrote: On Thu, Oct 19, 2017 at 06:15:49PM +0100, Suzuki K Poulose wrote: We zero out the entire trace buffer used for ETR before it is enabled, for helping with debugging. Since we could be restoring a session in perf mode, this could destroy the data. I'm no

Re: [PATCH 13/17] coresight etr: Do not clean ETR trace buffer

2017-11-02 Thread Mathieu Poirier
On Thu, Oct 19, 2017 at 06:15:49PM +0100, Suzuki K Poulose wrote: > We zero out the entire trace buffer used for ETR before it > is enabled, for helping with debugging. Since we could be > restoring a session in perf mode, this could destroy the data. I'm not sure to follow you with "... restoring

[PATCH 13/17] coresight etr: Do not clean ETR trace buffer

2017-10-19 Thread Suzuki K Poulose
We zero out the entire trace buffer used for ETR before it is enabled, for helping with debugging. Since we could be restoring a session in perf mode, this could destroy the data. Get rid of this step, if someone wants to debug, they can always add it as and when needed. Cc: Mathieu Poirier Signe