Re: [PATCH 12/44 take 2] [UBI] allocation unit implementation

2007-02-20 Thread Artem Bityutskiy
On Mon, 2007-02-19 at 13:13 +0200, Pekka Enberg wrote: > NAK. Please drop all of these utterly pointless kmalloc() and > kmem_cache_alloc() wrappers. Will be fixed. -- Best regards, Artem Bityutskiy (Битюцкий Артём) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

Re: [PATCH 12/44 take 2] [UBI] allocation unit implementation

2007-02-19 Thread Pekka Enberg
On 2/17/07, Artem Bityutskiy <[EMAIL PROTECTED]> wrote: +void *ubi_kzalloc(size_t size) +{ + void *ret; + + ret = kzalloc(size, GFP_KERNEL); + if (unlikely(!ret)) { + ubi_err("cannot allocate %zd bytes", size); + dump_stack(); + return N

Re: [PATCH 12/44 take 2] [UBI] allocation unit implementation

2007-02-19 Thread Artem Bityutskiy
On Sat, 2007-02-17 at 21:55 +0100, Arnd Bergmann wrote: > On Saturday 17 February 2007 17:55, Artem Bityutskiy wrote: > > +#include "wl.h" > > +#include "debug.h" > > +#include "eba.h" > > +#include "scan.h" > > I don't see much point in having one local header for each of these, > you could simpl

Re: [PATCH 12/44 take 2] [UBI] allocation unit implementation

2007-02-17 Thread Arnd Bergmann
On Saturday 17 February 2007 17:55, Artem Bityutskiy wrote: > diff -auNrp tmp-from/drivers/mtd/ubi/alloc.c tmp-to/drivers/mtd/ubi/alloc.c > +#include "ubi.h" > +#include "alloc.h" > +#include "io.h" > +#include "background.h" > +#include "wl.h" > +#include "debug.h" > +#include "eba.h" > +#include

[PATCH 12/44 take 2] [UBI] allocation unit implementation

2007-02-17 Thread Artem Bityutskiy
diff -auNrp tmp-from/drivers/mtd/ubi/alloc.c tmp-to/drivers/mtd/ubi/alloc.c --- tmp-from/drivers/mtd/ubi/alloc.c1970-01-01 02:00:00.0 +0200 +++ tmp-to/drivers/mtd/ubi/alloc.c 2007-02-17 18:07:26.0 +0200 @@ -0,0 +1,369 @@ +/* + * Copyright (c) International Business Machines