Re: [PATCH 12/41] perf tools: Fix leak of 'struct thread' on error path

2014-07-16 Thread Adrian Hunter
On 16/07/2014 5:02 p.m., Jiri Olsa wrote: On Mon, Jul 14, 2014 at 01:02:36PM +0300, Adrian Hunter wrote: __machine__findnew_thread() creates a 'struct thread' but does not free it on the error path. Signed-off-by: Adrian Hunter --- tools/perf/util/machine.c | 4 +++- tools/perf/util/thread.

Re: [PATCH 12/41] perf tools: Fix leak of 'struct thread' on error path

2014-07-16 Thread Jiri Olsa
On Mon, Jul 14, 2014 at 01:02:36PM +0300, Adrian Hunter wrote: > __machine__findnew_thread() creates a 'struct thread' > but does not free it on the error path. > > Signed-off-by: Adrian Hunter > --- > tools/perf/util/machine.c | 4 +++- > tools/perf/util/thread.c | 6 -- > 2 files changed,

Re: [PATCH 12/41] perf tools: Fix leak of 'struct thread' on error path

2014-07-14 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 14, 2014 at 01:02:36PM +0300, Adrian Hunter escreveu: > __machine__findnew_thread() creates a 'struct thread' > but does not free it on the error path. Ok, but that second one is a separate bug, i.e. its not fixing the described leak, please break this into two patches with separate co

[PATCH 12/41] perf tools: Fix leak of 'struct thread' on error path

2014-07-14 Thread Adrian Hunter
__machine__findnew_thread() creates a 'struct thread' but does not free it on the error path. Signed-off-by: Adrian Hunter --- tools/perf/util/machine.c | 4 +++- tools/perf/util/thread.c | 6 -- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/machine.c b/tool