Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-28 Thread Ondrej Zary
On Friday 28 August 2020 10:59:37 Kalle Valo wrote: > Ondrej Zary writes: > > > On Thursday 27 August 2020 09:49:12 Kalle Valo wrote: > >> Ondrej Zary writes: > >> > >> > On Monday 17 August 2020 20:27:06 Jesse Brandeburg wrote: > >> >> On Mon, 17 Aug 2020 16:27:01 +0300 > >> >> Kalle Valo wro

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-28 Thread Kalle Valo
Lee Jones writes: > On Fri, 28 Aug 2020, Kalle Valo wrote: > >> Ondrej Zary writes: >> >> > On Thursday 27 August 2020 09:49:12 Kalle Valo wrote: >> >> Ondrej Zary writes: >> >> >> >> > On Monday 17 August 2020 20:27:06 Jesse Brandeburg wrote: >> >> >> On Mon, 17 Aug 2020 16:27:01 +0300 >> >>

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-28 Thread Lee Jones
On Fri, 28 Aug 2020, Kalle Valo wrote: > Ondrej Zary writes: > > > On Thursday 27 August 2020 09:49:12 Kalle Valo wrote: > >> Ondrej Zary writes: > >> > >> > On Monday 17 August 2020 20:27:06 Jesse Brandeburg wrote: > >> >> On Mon, 17 Aug 2020 16:27:01 +0300 > >> >> Kalle Valo wrote: > >> >>

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-28 Thread Kalle Valo
Ondrej Zary writes: > On Thursday 27 August 2020 09:49:12 Kalle Valo wrote: >> Ondrej Zary writes: >> >> > On Monday 17 August 2020 20:27:06 Jesse Brandeburg wrote: >> >> On Mon, 17 Aug 2020 16:27:01 +0300 >> >> Kalle Valo wrote: >> >> >> >> > I was surprised to see that someone was using thi

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-27 Thread Ondrej Zary
On Thursday 27 August 2020 09:49:12 Kalle Valo wrote: > Ondrej Zary writes: > > > On Monday 17 August 2020 20:27:06 Jesse Brandeburg wrote: > >> On Mon, 17 Aug 2020 16:27:01 +0300 > >> Kalle Valo wrote: > >> > >> > I was surprised to see that someone was using this driver in 2015, so > >> > I'm

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-27 Thread Kalle Valo
Ondrej Zary writes: > On Monday 17 August 2020 20:27:06 Jesse Brandeburg wrote: >> On Mon, 17 Aug 2020 16:27:01 +0300 >> Kalle Valo wrote: >> >> > I was surprised to see that someone was using this driver in 2015, so >> > I'm not sure anymore what to do. Of course we could still just remove >>

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-17 Thread Ondrej Zary
On Monday 17 August 2020 20:27:06 Jesse Brandeburg wrote: > On Mon, 17 Aug 2020 16:27:01 +0300 > Kalle Valo wrote: > > > I was surprised to see that someone was using this driver in 2015, so > > I'm not sure anymore what to do. Of course we could still just remove > > it and later revert if someo

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-17 Thread Lee Jones
On Mon, 17 Aug 2020, Jesse Brandeburg wrote: > On Mon, 17 Aug 2020 16:27:01 +0300 > Kalle Valo wrote: > > > I was surprised to see that someone was using this driver in 2015, so > > I'm not sure anymore what to do. Of course we could still just remove > > it and later revert if someone steps up

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-17 Thread Jesse Brandeburg
On Mon, 17 Aug 2020 16:27:01 +0300 Kalle Valo wrote: > I was surprised to see that someone was using this driver in 2015, so > I'm not sure anymore what to do. Of course we could still just remove > it and later revert if someone steps up and claims the driver is still > usable. Hmm. Does anyone

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-17 Thread Kalle Valo
Lee Jones writes: > On Fri, 14 Aug 2020, Kalle Valo wrote: > >> Lee Jones writes: >> >> > - Ensure spaces appear after {for, if, while, etc} >> > - Ensure spaces to not appear after '(' >> > - Ensure spaces to not appear before ')' >> > - Ensure spaces appear between ')' and '{' >> > - Ens

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-14 Thread Lee Jones
On Fri, 14 Aug 2020, Kalle Valo wrote: > Lee Jones writes: > > > - Ensure spaces appear after {for, if, while, etc} > > - Ensure spaces to not appear after '(' > > - Ensure spaces to not appear before ')' > > - Ensure spaces appear between ')' and '{' > > - Ensure spaces appear after ',' >

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-14 Thread Kalle Valo
Lee Jones writes: > - Ensure spaces appear after {for, if, while, etc} > - Ensure spaces to not appear after '(' > - Ensure spaces to not appear before ')' > - Ensure spaces appear between ')' and '{' > - Ensure spaces appear after ',' > - Ensure spaces do not appear before ',' > - Ensure

[PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-14 Thread Lee Jones
- Ensure spaces appear after {for, if, while, etc} - Ensure spaces to not appear after '(' - Ensure spaces to not appear before ')' - Ensure spaces appear between ')' and '{' - Ensure spaces appear after ',' - Ensure spaces do not appear before ',' - Ensure spaces appear either side of '='